Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr81x l1t-tsg-v9 (part 1) for Sept 2016 MC production #15745

Merged
merged 27 commits into from Sep 7, 2016
Merged

Pr81x l1t-tsg-v9 (part 1) for Sept 2016 MC production #15745

merged 27 commits into from Sep 7, 2016

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Sep 6, 2016 •
edited

For easier review, the full l1t-tsg-v9 PR #15732 is broken in parts.

This is part 1.
It contains updates up to l1t-integration-v61.1

  • plus one commit (simBmtf does not use input identifiers in ReEmul and L1REPACK)
    needed for successful testing.

akalinow and others added 26 commits September 5, 2016 09:12
@akalinow @rekovic
* change numbering scheme for XML files.
1719057 
* add new version of XML files with modified names
* update filling of the CondFormats objects to follow the changed numbering scheme
@davignon @rekovic
Added custom variables for L1 taus to ntuples
8e51f1f
@thomreis @rekovic
Lut dumper loads LUTs from conditions object instead of file
5935de6
@thomreis @rekovic
remove unneeded custiomisation for lut dumper module
de98233
@jimbrooke @rekovic
add missing files for MC
935ac58
@jimbrooke @rekovic
bugfixes and naming corrections for gen info in ntuples
3733054
@jimbrooke @rekovic
fix a conflict
7ccb3b4
@jimbrooke @rekovic
fix conflicts
f501aad
@davignon @rekovic
Added courtesy variables for jets and e/g as well
debb737
@davignon @rekovic
Small change to courtesy variables for taus
41fc455
@rekovic
Fix L1TReEmulFromRaw workflow crash due to change in new BMTF unpacke…
aee6218 
…d inputs format
@rekovic
Unit-test update for re-emulation 2016
5366c62
@rekovic
Implement L1REPACK:Full,:uGT,:Full2015Data workflows
016b7af
@rekovic
Specify local L1Menu XML for reemulation of 2016 data
d87753f
@rekovic
Unit-test: new compare2 for reemulated 2016 data
d289d87
@rekovic
Multiple Tau isolation LUTs functionality for cross-triggers and Tau …
75e3372 
…packer/unpacker update to accomodate the additional isolation bit (rebased PR 277)
@jimbrooke @rekovic
turn off JEC for calibration derivation
ff762f3
@jimbrooke @rekovic
check product is valid before using
94854e3
@rekovic
revert hackConditions_cff to pre tsg-v7.
3a9ca17
@konec @rekovic
assigne eta=+-121 to CSC hits with keyWG above |eta|=1.3, then filter…
486ef4d 
… them

set q=4 to muons with |eta|=115,
remove layers 7,8,9 from list of layers with q-4
minor fixes to CSC keywire group assignment to eta code
@konec @rekovic
slightly tune/modify condition of q=4 for |eta|==115.
d6826a2 
Now it is done if in case |eta|==115 and hits are ONLY in 3 layers out of (7,8,9,17)
@konec @rekovic
In case of |eta| 121 set its quality to 4.
4c073b2 
It has no effect for MC shince hits with this quality are filtered out, but
is usefull for data-MC comparistion (if one remove the filter)
@mulhearn @rekovic
remove unneded HF customizations from tests, and add all available co…
6d28506 
…mparisons to local comparison test
@rekovic
Change default caloParams to use Tau Iso Option 21 (caloStage2Params_…
1d7e790 
…2016_v2_2_cfi)
@rekovic
Adding L1REPACK FullMC to run on RAW of MC. Fix Csc tag for Omtf emul…
4d63131 
…ator in REPACK:Full, and clean REPACK:uGT
@rekovic
Remove simBmtf input identfiers in ReEmul and sync L1REPACK
3d5a1aa
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 6, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

A new Pull Request was created by @rekovic for CMSSW_8_1_X.

It involves the following packages:

Configuration/Applications
Configuration/StandardSequences
DataFormats/L1Trigger
EventFilter/L1TRawToDigi
L1Trigger/Configuration
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TMuonOverlap
L1Trigger/L1TNtuples

@cmsbuild, @rekovic, @franzoni, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Sep 6, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14967/console

@rekovic rekovic mentioned this pull request Sep 6, 2016
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

Pull request #15745 was updated. @cmsbuild, @rekovic, @franzoni, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor Author

rekovic commented Sep 6, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

The tests are being triggered in jenkins.

@davidlange6
Copy link
Contributor

@rekovic - thanks - I don't see anything to update in this PR - so assuming tests are ok, I'll merge it today. Then you can rebase the next one for review...

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

+1
Tested at: 3d5a1aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15745/14967/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15745/14967/summary.html

@davidlange6 davidlange6 merged commit 52dd9ee into cms-sw:CMSSW_8_1_X Sep 7, 2016
@thomreis thomreis mentioned this pull request Sep 7, 2016
Merged
@rekovic rekovic mentioned this pull request Sep 8, 2016
Open
5 tasks
@rekovic rekovic mentioned this pull request Sep 15, 2016
Closed
@rekovic rekovic mentioned this pull request Sep 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending operations-pending orp-pending pending-signatures tests-started
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rekovic @cmsbuild @davidlange6 @akalinow @davignon @thomreis @jimbrooke @konec @mulhearn