bsunanda:Run2-TB10 correct beam line description of CERN HGCal test beam simulation #15766
Conversation
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
geometry-approved
simulation-approved
and removed
geometry-pending
pending-signatures
simulation-pending
labels
| if (layer<(int)(hSimHitLayEn2E_.size())) { | ||
| simHitLayEn2E[layer] = energy; | ||
| hSimHitLayEn2E_[layer]->Fill(energy); | ||
| if (layer-1 < (int)(hSimHitLayEn2E_.size())) { |
There was a problem hiding this comment.
note that layer is never used aside from layer-1 - perhaps wise to define layer= itr->first -1; ? @bsunanda
|
Pull request #15766 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@civanch It needs your signature again - modified to take care of David's comments |
|
+1 |
No description provided.