Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sherpa weights when no weight list is provided #15775

Merged
merged 1 commit into from Oct 4, 2016

Conversation

thuer
Copy link
Contributor

@thuer thuer commented Sep 8, 2016

Backport of the fix of sherpaweights (#15733)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

A new Pull Request was created by @thuer (Sebastian Thüer) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/SherpaInterface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@perrozzi
Copy link
Contributor

perrozzi commented Sep 8, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15032/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

-1

Tested at: 0289558

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15775/15032/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

@thuer
Copy link
Contributor Author

thuer commented Sep 8, 2016

that error is not related to the pull request.

@thuer
Copy link
Contributor Author

thuer commented Sep 9, 2016

can we test again?

@perrozzi
Copy link
Contributor

perrozzi commented Sep 9, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15065/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 97d1fd8 into cms-sw:CMSSW_7_1_X Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants