Infrastructure to create the actual ValueMap pat::Tau-discriminator for tau isolation and ID #15778
Conversation
…licit dictionary changes in classes_objects.h and classes_def_objects.xml)
… to achieve consistentcy with miniAOD outputs
…oading of functions -- on that way down-graded outputs for PFRecoTauDiscriminator from double to float to be consistent with miniAOD outputs
…pog_miniAOD-tauID
|
A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_1_X. It involves the following packages: DataFormats/PatCandidates @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| <class name="pat::PATTauDiscriminatorBase"> | ||
| <field name="transientVector_" transient="true"/> | ||
| </class> | ||
| <class name="pat::PATTauDiscriminator"/> |
There was a problem hiding this comment.
add versions to non-templated classes
There was a problem hiding this comment.
Ok -- if've done as advised. PATTauDiscriminator now has a class version 3. The PATTauDiscriminatorBase is a templated class.
|
@cmsbuild please test ... mainly to get static analysis results and see the new unit test complete. |
|
The tests are being triggered in jenkins. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
This is a pull request to layout the infrastructure to create the actual pat::Tau-discriminator ValueMap.
The PATTauDiscriminator.h is declared in DataFormats/PatCandidate. The classes for filling are provided in RecoTauTag/RecoTau:
Several other files have been modified to account for the existence new discriminator or to adapt helper functions to be able to act on the PATTauDiscriminator as well as on the PFTauDiscriminator. The input values for the AOD based discriminator calculation have been downgraded to float, since this is the available level of accuracy on miniAOD. This has been done with the premiss to guarantee that the MVA return values are the same irrespective of whether AOD or miniAOD has been used as input to the calculation. A few files have been added to the RecoTauTag/RecoTau/test directory for unit testing.
Usual checks have been made (apart from runMatrix problems with CMS_DAS). Also internal tests show that already existing workflows are not altered or compromised in any way. The unit test show that the discriminator can be calculated on miniAOD event content and read-in at analysis level and that it returns identical results to the discriminator as calculated on AOD input at an accuracy of 10e-5. Residual differences are understood in terms of differences on the miniAOD input variables.
We would like to get this infrastructure integrated in time for CMSSW_8_1_0_pre12.
Potentially we would like to backport it to 80X: it does not change any existing event content while it clearly add a new object to the EDM. In the typical case the new objects will be used at the analysis level and will be transient. The use case is also expressed by the fact that the new data object is defined in the AT packages DataFormats/PatCandidates. We anticipate that the backport might be subject of debate and rely on our assessment.
As for the extension of the miniAOD event content before we have one more development that is a bit lacking behind but that we would like to be integrated on the same time scale for the anti-electron discriminator. We hope that we can prepare this PR by tomorrow based on the infrastructure that has been laid out here. It will then ideally only add the plugins to calculate the physically different discriminator values using the PATTauDiscriminator infrastructure introduced with this PR. It will therefore not be as extended in lines of new/altered code as this PR.
Cheers,
Roger