Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new SiStripFedCabling API for feds. #1579

Merged
merged 1 commit into from Dec 1, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 25, 2013

  • New API uses iterator pairs rather than container references,
    adapt everywhere to it.
  • Get rid of the obsolete API, which is thread unsafe.

- New API uses iterator pairs rather than container references,
  adapt everywhere to it.
- Get rid of the obsolete API, which is thread unsafe.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Migrate to the new SiStripFedCabling API for feds.

It involves the following packages:

Alignment/LaserAlignment
CondFormats/SiStripObjects
DQM/SiStripMonitorHardware
DQMOffline/CalibTracker
CalibFormats/SiStripObjects
CalibTracker/SiStripCommon
DQM/SiStripCommissioningDbClients
DQM/SiStripCommissioningSources
CommonTools/TrackerMap
CalibTracker/SiStripESProducers
DPGAnalysis/SiStripTools
DQM/SiStripMonitorClient
DQM/SiStripCommissioningSummary
EventFilter/SiStripRawToDigi

@apfeiffer1, @thspeer, @demattia, @danduggan, @rovere, @cmsbuild, @nclopezo, @rcastello, @deguio, @slava77, @ggovi, @vadler, @eliasron can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor Author

ktf commented Nov 25, 2013

@mtosi you might actually be interested in this as well.

@cmsbuild
Copy link
Contributor

@vadler
Copy link

vadler commented Nov 25, 2013

@cmsbuild, @ktf : Hmm, I can see some errors in TestSiStripDCS, which don't crash the tests explicitly.

@ktf
Copy link
Contributor Author

ktf commented Nov 25, 2013

@vadler
Copy link

vadler commented Nov 25, 2013

+1
Nothing to complain from AT.

@thspeer
Copy link
Contributor

thspeer commented Nov 26, 2013

+1
Tested c549611 in CMSSW_7_0_X_2013-11-25-0200-1579
No difference in reco as expected, based on RelMon and reco script

@deguio
Copy link
Contributor

deguio commented Nov 28, 2013

+1

@apfeiffer1
Copy link
Contributor

+1
pJa

@cmsbuild
Copy link
Contributor

@demattia
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 1, 2013
DQM updates -- Migrate to the new SiStripFedCabling API for feds.
@ktf ktf merged commit b5f4e6f into cms-sw:CMSSW_7_0_X Dec 1, 2013
@ktf ktf deleted the fix-fed-migration branch June 4, 2014 07:34
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants