ECAL Digitizer Optimizations #15835
ECAL Digitizer Optimizations #15835
Conversation
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X. It involves the following packages: SimCalorimetry/EcalSimAlgos @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
lgray
changed the title
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
lgray
force-pushed
the
topic_remove_RandPoisQ
branch
from
51c8772
to
6a7907d
Compare
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Pull request #15835 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
lgray
changed the title
|
@cmsbuild please test Don't see this in jenkins. |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-started
tests-pending
labels
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
@lgray - what is the motivation for the float->double changes? |
|
@davidlange6 The way it was done it was a completely unnecessary step to pass a double as a float and then convert it back to double since it was used in double math anyway. It was just wasting instructions on converting the variables back and forth. |
|
+1 |
The RandPoissonQ destructor was taking up 2% of processing time in high pileup / fast timing conditions. This PR removes the instantiation of the class, using the static method instead.
Likewise in high pileup or with fast timing turned on for ECAL, multiple calls to the laser correction service were causing a huge load in the ecal digitizer. This is now fixed with a tactical cache that is updated every event since the corrections are time dependent.
Technical PR, no changes expected/observed.