Use unique_ptr, not auto_ptr in RecoEgamma and RecoEcal

[wmtan]

In preparation for removing framework support for deprecated auto_ptr arguments in put() calls, this pull request replaces the use of auto_ptr with unique_ptr in RecoEgamma and RecoEcal packages. Also, std::make_unique is used when appropriate. Also, there was a case where a reference to an auto_ptr was an input argument to a function, which is a bad practice because it obscures the possible transfer of ownership. In the cases here, ownership was transferred, so the unique_ptr was passed by value.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaClusterProducers
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaHFProducers
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @battibass, @rafaellopesdesa, @argiro, @HuguesBrun, @lgray this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[wmtan]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15145/console

[fwyzard]

+1

[fwyzard]

I have a related question, though it goes beyond the scope of this PR.

I see that in many modules, a RecoEcalCandidateIsolationMap is first built on the stack, and later copied into an std::unique_ptr<RecoEcalCandidateIsolationMap> , which is then moved into the event.

Does this actually incur in an additional copy ?
Would it be better to build the object on the heap in the first place ?

[cmsbuild]

+1
Tested at: c37e7a0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15857/15145/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15857/15145/summary.html

[cvuosalo]

+1

For #15857 c37e7a0

Migrating deprecated auto_ptr to unique_ptr in RecoEgamma and RecoEcal. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-14-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1