Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80X backport: Protect against invalide TSOS #15892

Merged
merged 2 commits into from Sep 21, 2016

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Sep 17, 2016

This is the 80X backport of #15891

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_8_0_X.

It involves the following packages:

RecoMuon/GlobalTrackingTools

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @calderona, @HuguesBrun, @battibass, @trocino, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2016

backport of #15891

for the bot to apply a label

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2016

type bugfix
for the bot to apply a label

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15243/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 19, 2016

+1

for #15892 38f8fa5

  • changes are in line with the description, affecting only events that would otherwise have a crash in processing. Changes in the code are the same as in the 81X PR Protect against invalide TSOS #15891
  • jenkins tests pass and comparisons with baseline show no differences
  • It looks like the raw files for the crashing jobs in 280349 are no longer on disk. So, I did not test if all issues are resolved with this fix. Signing, assuming @jhgoh and @HuguesBrun checked this runs on the problematic events.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 408746e into cms-sw:CMSSW_8_0_X Sep 21, 2016
@jhgoh jhgoh deleted the MuonDYTInvalidTSOSProtection80X branch October 17, 2016 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants