Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microstate monitoring update (DAQ) 81X #15955

Merged
merged 5 commits into from Sep 29, 2016

Conversation

smorovic
Copy link
Contributor

Fixes to microstate monitoring in DAQ EvF:

  • Global EoL microstate state should not be set in initialization stage.
  • GlobalEoL should only be set for thread/stream after postStreamEndLumi
  • Per thread/stream breakdown of some states for input state monitoring (to analyze the effective impact of limitations imposed by the multithreading model).
  • Two states removed, two new input states added

PR also includes new test mode for FedRawDataSource used to fill ramdisk in fakeBU mode looping over events from raw files.

…to state of framework streams/threads)

*GlobalEoL microstate set only for threads already in FwkEoL
*fix for the initialisation state which was appearing as GlobalEoL
*flag for Auxiliarymakers to skip warning which appears in loop mode due to lumisection mismatch
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_1_X.

It involves the following packages:

EventFilter/Utilities

@cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15344/console

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15955/15344/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+HARVESTFull_2017NewFPix

@cvuosalo
Copy link
Contributor

+1

For #15955 c0fbc6f

For the DAQ, fixes for microstate monitoring. There should be no change in offline monitored quantities.

#15956 is the 80X version of this PR.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-22-0900 show no significant differences, as expected.

@emeschi
Copy link
Contributor

emeschi commented Sep 28, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a083945 into cms-sw:CMSSW_8_1_X Sep 29, 2016
@smorovic smorovic deleted the microstates-update-81X branch February 13, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants