Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of configuration for boostedTau creation #15996

Merged

Conversation

roger-wolf
Copy link
Contributor

Dear all,

this is a PR with a minor modification of the configuration for the creation of boostedTaus. The only file that really has anything to do with the modification as such is

RecoTauTag/Configuration/python/boostedHPSPFTaus_cfi.py (lines 22 & 23)

The other files are part of a infrastructure that we use for our internal testing and validation (e.g. of this change), which has been extended to be able also to validate boostedTaus now.

The modification as such loosens the anti-muon discriminator requirement to be more efficient for the identification of boostedTaus. It has been verified that this increases the efficiency of the identification of boostedTaus in the relevant kinematic regimes, where two taus might be very close to each other. For non-boosted taus the expected behaviour is:

  1. no difference on normal taus (obviously);
  2. only small to tiny differences on boostedTaus (in the usually tested regimes for release validation);
  3. if changes occur they should only be visible in the anti-muon discriminators (loose and tight WP) and lead to an increased probability to pass the discriminator value.

Usual tests have been made w/o notice of any problems.

Cheers,
Roger

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_1_X.

It involves the following packages:

RecoTauTag/Configuration

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15408/console

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

@cmsbuild please test
Look like the last Jenkins comparisons failed -- trying again

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15421/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #15996 a52d503

Small configuration change to improve boosted tau ID efficiency.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-28-1100 show no significant differences. A test of workflow 25202.0_TTbar_13 with 100 events against baseline CMSSW_8_1_X_2016-09-27-1100 also shows no significant differences. CPU time (without DQM or Validation) for the affected module appears to improve by almost 10%:

  delta/mean delta/orJob     original                   new       module name
  ---------- ------------     --------                  ----       ------------
    -0.080255      -0.05%        78.75 ms/ev ->        72.67 ms/ev recoTauAK4PFJets08RegionBoosted
  ---------- ------------     --------                  ----       ------------

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Sep 29, 2016

On 9/29/16 3:14 PM, Carl Vuosalo wrote:

+1

For #15996 #15996 a52d503
a52d503

Small configuration change to improve boosted tau ID efficiency.

The code changes are satisfactory, and Jenkins tests against baseline
CMSSW_8_1_X_2016-09-28-1100 show no significant differences. A test of
workflow 25202.0_TTbar_13 with 100 events against baseline
CMSSW_8_1_X_2016-09-27-1100 also shows no significant differences.

Looks like the boosted taus are not monitored in miniAOD DQM.
TAU POG better add some standard validation for this rather costly
reconstruction

CPU
time (without DQM or Validation) for the affected module appears to
improve by almost 10%:

|delta/mean delta/orJob original new module name ---------- ------------
-------- ---- ------------ -0.080255 -0.05% 78.75 ms/ev -> 72.67 ms/ev

recoTauAK4PFJets08RegionBoosted ---------- ------------ -------- ----

this must be random

the modified modules
hpsPFTauDiscriminationBy{Loose,Tight}MuonRejection3Boosted
are running after recoTauAK4PFJets08RegionBoosted


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15996 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcblj9ZaFNdgFc-RBsQjPt18U9Ra-aks5qvDg0gaJpZM4KHjK2.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c35f716 into cms-sw:CMSSW_8_1_X Sep 30, 2016
@roger-wolf roger-wolf deleted the CMSSW_8_1_X_tau-pog_boosted-tau-RECO branch February 24, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants