Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable SiPM hardcode parameters #16002

Merged
merged 5 commits into from Sep 30, 2016

Conversation

kpedro88
Copy link
Contributor

Changes in this PR (all in the HCAL hardcode conditions):

  1. Add python parameter to enable/disable useHOUpgrade
  2. Configurable SiPM per-channel parameters: photoelectronsToAnalog, darkCurrent
  3. Configurable SiPM per-type parameters: pixels, crosstalk, nonlinearity params
  4. Assign SiPM type based on number of layers in depth (taken from topology): cells with nLayers > 4 have larger SiPMs of diameter 3.3mm, the rest have SiPMs of diameter 2.8mm

I tested the operation of these changes using the following (slightly cumbersome) command, assuming the workflow numbering in pre12 (so 106xx is 2017HCALdev):

runTheMatrix.py -w upgrade -l 10622.0 --command='--customise SLHCUpgradeSimulations/Configuration/HCalCustoms.load_HcalHardcode --customise_commands "process.es_hardcode.useHFUpgrade = cms.bool(True)\nprocess.es_hardcode.useHEUpgrade = cms.bool(True)\nprocess.es_hardcode.toGet.remove(\"ElectronicsMap\")"'

It is also necessary to uncomment these two lines:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_0_pre12/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc#L64-L65
because the new DB objects are not yet activated in the official software. Correspondingly, no changes are expected in any central workflows.

attn: @abdoulline, @bsunanda

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15411/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2016

+1
@kpedro88 for the record:

It is also necessary to uncomment these two lines:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_0_pre12/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc#L64-L65
because the new DB objects are not yet activated in the official software. Correspondingly, no changes are expected in any central workflows.

could be activated after #16048 is merged

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 12aa3ff into cms-sw:CMSSW_8_1_X Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants