New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable SiPM hardcode parameters #16002
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/HcalAlgos @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
could be activated after #16048 is merged |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Changes in this PR (all in the HCAL hardcode conditions):
useHOUpgrade
nLayers > 4
have larger SiPMs of diameter 3.3mm, the rest have SiPMs of diameter 2.8mmI tested the operation of these changes using the following (slightly cumbersome) command, assuming the workflow numbering in pre12 (so 106xx is 2017HCALdev):
It is also necessary to uncomment these two lines:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_0_pre12/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc#L64-L65
because the new DB objects are not yet activated in the official software. Correspondingly, no changes are expected in any central workflows.
attn: @abdoulline, @bsunanda