New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable anode timing measurement in case energy measurement is disabled #16005
Conversation
A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_8_1_X. It involves the following packages: RecoLocalCalo/HcalRecAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Minor fix -- this change discards the TDC time contribution from a PMT anode into a rechit if its energy measurement has been discarded. In the previous version of the code, it would potentially be possible to pick up timing measurement from the anode without using the energy (nor a logical thing to do).