Update hardcoded LutMetadata for HCAL TP #16011

matz-e · 2016-09-28T13:27:01Z

Revert the gain that was changed in the 6XY series back to its original value
Provide mores sensible RCalib values for running with Phase1 upgrades
Adjust TDC mask to cover all allowed values for now (missing 4 highest bits)

Revert gain (which was changed in 6XY) back to 0.177 and provide better values for rcalib etc corresponding to the 2017 era.

cmsbuild · 2016-09-28T13:27:16Z

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

kpedro88 · 2016-09-28T13:46:26Z

@cmsbuild please test

cmsbuild · 2016-09-28T13:46:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15413/console

cmsbuild · 2016-09-28T15:36:40Z

+1
Tested at: fac278a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16011/15413/summary.html

cmsbuild · 2016-09-28T16:26:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16011/15413/summary.html

kpedro88 · 2016-09-30T16:57:14Z

@mmusich can you approve this? (Corresponding database conditions have already been updated and approved in #16048...)

mmusich · 2016-09-30T17:06:55Z

+1

cmsbuild · 2016-09-30T17:07:07Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

davidlange6 · 2016-10-02T13:52:03Z

CalibCalorimetry/HcalPlugins/src/HcalHardcodeCalibrations.cc

+    if (dbHardcode.useHEUpgrade() or dbHardcode.useHFUpgrade()) {
+       switch (cell.genericSubdet()) {
+          case HcalGenericDetId::HcalGenBarrel:
+             rcalib = 1.128;


@matz-e - could you add a few comments to explain where these hardcoded numbers came from? Thanks

@davidlange6 yes, I can do that. I'm not sure where the originals (L609 that I removed/changed) came from, but I can at least document the changes.

cmsbuild · 2016-10-04T01:58:38Z

Pull request #16011 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

matz-e · 2016-10-04T01:58:58Z

Documented new hardcoded values…

mmusich · 2016-10-04T05:55:17Z

+1

mmusich · 2016-10-04T05:55:23Z

please test

cmsbuild · 2016-10-04T05:55:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15510/console

cmsbuild · 2016-10-04T05:55:33Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

kpedro88 · 2016-10-05T15:28:16Z

looks like tests timed out for some reason

kpedro88 · 2016-10-05T15:28:23Z

@cmsbuild please test

cmsbuild · 2016-10-05T15:28:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15547/console

cmsbuild · 2016-10-05T16:54:30Z

+1
Tested at: 7ac719b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16011/15547/summary.html

cmsbuild · 2016-10-05T18:02:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16011/15547/summary.html

matz-e added 2 commits September 28, 2016 15:20

Fix hardcoded TDC mask for HF.

c155b4d

Provide better hardcoded values for LutMetadata.

fac278a

Revert gain (which was changed in 6XY) back to 0.177 and provide better values for rcalib etc corresponding to the 2017 era.

cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 28, 2016

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures tests-pending labels Sep 28, 2016

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2016

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2016

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2016

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Sep 30, 2016

davidlange6 reviewed Oct 2, 2016

View reviewed changes

Mention where these values come from.

7ac719b

cmsbuild removed alca-approved comparison-available labels Oct 4, 2016

cmsbuild added comparison-pending pending-signatures tests-pending labels Oct 4, 2016

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Oct 4, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 4, 2016

cmsbuild added tests-pending and removed tests-started labels Oct 5, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 5, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 5, 2016

davidlange6 merged commit f3a1e12 into cms-sw:CMSSW_8_1_X Oct 6, 2016

matz-e deleted the hcal-tp-2017-hardcode branch September 15, 2017 15:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update hardcoded LutMetadata for HCAL TP #16011

Update hardcoded LutMetadata for HCAL TP #16011

matz-e commented Sep 28, 2016 •

edited

cmsbuild commented Sep 28, 2016

kpedro88 commented Sep 28, 2016

cmsbuild commented Sep 28, 2016 •

edited

cmsbuild commented Sep 28, 2016

cmsbuild commented Sep 28, 2016

kpedro88 commented Sep 30, 2016

mmusich commented Sep 30, 2016

cmsbuild commented Sep 30, 2016

davidlange6 Oct 2, 2016

matz-e Oct 3, 2016

cmsbuild commented Oct 4, 2016

matz-e commented Oct 4, 2016

mmusich commented Oct 4, 2016

mmusich commented Oct 4, 2016

cmsbuild commented Oct 4, 2016 •

edited

cmsbuild commented Oct 4, 2016

kpedro88 commented Oct 5, 2016

kpedro88 commented Oct 5, 2016

cmsbuild commented Oct 5, 2016 •

edited

cmsbuild commented Oct 5, 2016

cmsbuild commented Oct 5, 2016

Update hardcoded LutMetadata for HCAL TP #16011

Update hardcoded LutMetadata for HCAL TP #16011

Conversation

matz-e commented Sep 28, 2016 • edited

cmsbuild commented Sep 28, 2016

kpedro88 commented Sep 28, 2016

cmsbuild commented Sep 28, 2016 • edited

cmsbuild commented Sep 28, 2016

cmsbuild commented Sep 28, 2016

kpedro88 commented Sep 30, 2016

mmusich commented Sep 30, 2016

cmsbuild commented Sep 30, 2016

davidlange6 Oct 2, 2016

Choose a reason for hiding this comment

matz-e Oct 3, 2016

Choose a reason for hiding this comment

cmsbuild commented Oct 4, 2016

matz-e commented Oct 4, 2016

mmusich commented Oct 4, 2016

mmusich commented Oct 4, 2016

cmsbuild commented Oct 4, 2016 • edited

cmsbuild commented Oct 4, 2016

kpedro88 commented Oct 5, 2016

kpedro88 commented Oct 5, 2016

cmsbuild commented Oct 5, 2016 • edited

cmsbuild commented Oct 5, 2016

cmsbuild commented Oct 5, 2016

matz-e commented Sep 28, 2016 •

edited

cmsbuild commented Sep 28, 2016 •

edited

cmsbuild commented Oct 4, 2016 •

edited

cmsbuild commented Oct 5, 2016 •

edited