new plots for tracking DQM 81x #16013
Conversation
|
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X. It involves the following packages: DQM/TrackingMonitor @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 Adding new tracking DQM plots. There should be no change in monitored RECO quantities. #16014 is the 80X version of this PR, and it has already been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-28-1100 show the new DQM plots and no other significant differences, as expected. |
| << ". Please update also TrackAnalyzer.cc near line " << __LINE__ << "."; | ||
| << " but StopReasonName's only for " | ||
| << StopReasonNameSize | ||
| << ". Please update DataFormats/TrackReco/interface/TrajectoryStopReasons.h."; |
There was a problem hiding this comment.
This check would be better implemented as a static_assert in DataFormats/TrackReco/interface/TrajectoryStopReasons.h
| "MAX_CCC_LOST_HITS", // 8 | ||
| "NO_SEGMENTS_FOR_VALID_LAYERS", // 9 | ||
| "SEED_EXTENSION", // 10 | ||
| "NOT_STOPPED" // 11 (be careful ...) |
There was a problem hiding this comment.
Could you improve the comment (essentially that NOT_STOPPED needs to be the last, and that it's index differs from the enumeration value)? I had to think a bit again what was going on :)
There was a problem hiding this comment.
thanks @makortel,
I think I've just addressed both comments, but the one on the static_assert
cmsbuild
added
comparison-pending
and removed
comparison-available
reconstruction-approved
tests-approved
labels
|
Pull request #16013 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
as suggested by matti
mtosi
force-pushed
the
fixTrackingDQM81x
branch
from
abdf793
to
3011d87
Compare
|
Pull request #16013 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
as requested by tracking POG,
some new plots have been added to the tracking DQM
in addition, I fix the track stopping source name by adding a dedicated list of strings