Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment validation bugfixes #16019

Merged
merged 2 commits into from Sep 29, 2016
Merged

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Sep 28, 2016

  • Error message was in a function that never got called, so it would just proceed silently and ignore firstRun and lastRun. This bit several people.
  • Also was missing .oO[Alignment/OfflineValidation]Oo. in creating the parallel jobs merge script repmap, need to apply PlottingOptions to get it.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_8_1_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15432/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ghellwig
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a08c942 into cms-sw:CMSSW_8_1_X Sep 29, 2016
@hroskes hroskes deleted the fix-error-message branch October 4, 2016 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants