Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass on migration from Reflex to root-6 for Conditions, still some work to do. #1603

Merged
merged 5 commits into from Nov 27, 2013
Merged

First pass on migration from Reflex to root-6 for Conditions, still some work to do. #1603

merged 5 commits into from Nov 27, 2013

Conversation

apfeiffer1
Copy link
Contributor

First pass on migration from Reflex to root-6 for Conditions, still some work to do.
Please merge this into the ROOT-6 IB.

@apfeiffer1
moved away from Reflex to edm ...WithDict classes to make CondCore/DB…
d3377c9 
…Common build.
@apfeiffer1
round zero of Conditions migration to root6 - most simple things move…
dcfc784 
…d to new edm *WithDict classes
@apfeiffer1
more work on moving away from Reflex.
53e09b7 
Moved to use recipes from Bill and Paul for ObjectWithDict::invoke()
added helper functions to implement BaseSize(), BaseAt(index) and DataMemberAt(index)
according to Bill's recipe
Renamed a few isArray() calls back to IsArray() to make the error messages homogeneous
@apfeiffer1
another round of changes for the migration from reflex to root-6
9b8b091 
added src/CondProperties.h which is a generated map containing for each class
the properties from the class_def.xml files.
src/RflxCollProxy.h still needs the implementations for all methods.
@apfeiffer1
next round in move from reflex to root6. fixed more build errors. mov…
7427d57 
…ed away from CondProperties to use TClassAttributeMap as suggested by Paul
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_0_ROOT6_X.

First pass on migration from Reflex to root-6 for Conditions, still some work to do.

It involves the following packages:

CondCore/DBCommon
CondCore/ORA

@apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Nov 27, 2013
@ktf
Merge pull request #1603 from apfeiffer1/ap-root6-condMigration
67e4f5b 
ROOT 6 -- First pass on migration from Reflex to ROOT6 for Conditions.
@ktf ktf merged commit 67e4f5b into cms-sw:CMSSW_7_0_ROOT6_X Nov 27, 2013
@apfeiffer1
Copy link
Contributor Author

+1
....

On Wed, Nov 27, 2013 at 11:13 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1https://github.com/apfeiffer1(Andreas Pfeiffer) for CMSSW_7_0_ROOT6_X.

First pass on migration from Reflex to root-6 for Conditions, still some
work to do.

It involves the following packages:

CondCore/DBCommon
CondCore/ORA

@apfeiffer1 https://github.com/apfeiffer1, @nclopezohttps://github.com/nclopezo,
@demattia https://github.com/demattia, @cmsbuildhttps://github.com/cmsbuild,
@rcastello https://github.com/rcastello, @ggovihttps://github.com/ggovican you please review it and eventually sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1603#issuecomment-29373145
.

Thanks,
cheers, andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending db-pending pending-signatures tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apfeiffer1 @cmsbuild @ktf