clang compilation error undefined reference to Phase2ITPixelCluster::MAXSPAN

[gartung]

Fix for this clang compilation error:

Building shared library tmp/slc6_amd64_gcc530/src/DataFormats/Phase2ITPixelCluster/src/DataFormatsPhase2ITPixelCluster/libDataFormatsPhase2ITPixelCluster.so
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/llvm/3.8.0-giojec/bin/clang++ -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++14 -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Wa,--compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=uninitialized -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -DBOOST_DISABLE_ASSERTS -Wno-error=unused-variable -shared -Wl,-E -Wl,-z,defs tmp/slc6_amd64_gcc530/src/DataFormats/Phase2ITPixelCluster/src/DataFormatsPhase2ITPixelCluster/a/DataFormatsPhase2ITPixelCluster_xr.o tmp/slc6_amd64_gcc530/src/DataFormats/Phase2ITPixelCluster/src/DataFormatsPhase2ITPixelCluster/Phase2ITPixelCluster.o tmp/slc6_amd64_gcc530/src/DataFormats/Phase2ITPixelCluster/src/DataFormatsPhase2ITPixelCluster/Phase2ITPixelClusterShapeCache.o -o tmp/slc6_amd64_gcc530/src/DataFormats/Phase2ITPixelCluster/src/DataFormatsPhase2ITPixelCluster/libDataFormatsPhase2ITPixelCluster.so -Wl,-E -Wl,--hash-style=gnu -L/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/86f7302e2fcfe09cffbe98f72c4e9e89/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_CLANG_X_2016-09-28-1100/lib/slc6_amd64_gcc530 -L/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/86f7302e2fcfe09cffbe98f72c4e9e89/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_CLANG_X_2016-09-28-1100/external/slc6_amd64_gcc530/lib -lDataFormatsCommon -lDataFormatsProvenance -lFWCoreMessageLogger -lDataFormatsStdDictionaries -lFWCoreUtilities -lTree -lNet -lThread -lMathCore -lRIO -lboost_filesystem -lCore -lboost_regex -lboost_system -lpcre -lboost_thread -lboost_signals -lboost_date_time -lbz2 -luuid -ltbb -lz -lcms-md5 -lnsl -lcrypt -ldl -lrt -ltinyxml
tmp/slc6_amd64_gcc530/src/DataFormats/Phase2ITPixelCluster/src/DataFormatsPhase2ITPixelCluster/Phase2ITPixelCluster.o: In function Phase2ITPixelCluster::add(Phase2ITPixelCluster::PixelPos const&, unsigned int)': /build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/86f7302e2fcfe09cffbe98f72c4e9e89/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_CLANG_X_2016-09-28-1100/src/DataFormats/Phase2ITPixelCluster/src/Phase2ITPixelCluster.cc:(.text+0x9a6): undefined reference toPhase2ITPixelCluster::MAXSPAN'
clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation)

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/Phase2ITPixelCluster

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[gartung]

@Dr15Jones

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15458/console

[cvuosalo]

@cmsbuild please test
Jenkins failed, trying again

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15464/console

[cmsbuild]

+1
Tested at: aad0dc8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16040/15464/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16040/15464/summary.html

[cvuosalo]

+1

For #16040 aad0dc8

Fixing Clang compile error for Phase2ITPixelCluster. There should be no change in compiled output.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-29-2300 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1