Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for getting Sequence labels #1607

Merged
merged 1 commit into from Dec 2, 2013

Conversation

SusieMurphy
Copy link
Contributor

Bug fix for how labels are obtained and error handling added for cases of unexpected failure, so that other files are still calculated.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SusieMurphy for CMSSW_7_0_X.

Bug fix for getting Sequence labels

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test testFWCoreUtilities had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1607/1510/summary.html

@Dr15Jones
Copy link
Contributor

That error is not related to the code change. It is a spurious bug in the actual test.

nclopezo added a commit that referenced this pull request Dec 2, 2013
Bug fix for getting Sequence labels
@nclopezo nclopezo merged commit f5f301a into cms-sw:CMSSW_7_0_X Dec 2, 2013
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Remove patch for symlink and force them through makefile options instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants