Phase2 Timing Layer Geometry #16081
Phase2 Timing Layer Geometry #16081
Conversation
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @alja, @srimanob, @franzoni, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #16081 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @alja, @srimanob, @franzoni, @hengne, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
I can't see the changes in code. I have this message: |
|
Why I can't view the changes ? |
|
@alja You need to click the button at the bottom of the "new review changes" panel then it will go away. |
|
+1 |
|
@davidlange6 Can you let me know what is missing here for a merge? |
|
a PDMV signature, but I just skipped it.. |
|
|
||
| XMLIdealGeometryESSource = cms.ESSource("XMLIdealGeometryESSource", | ||
| geomXMLFiles = cms.vstring( | ||
| 'Geometry/CMSCommonData/data/PhaseII/materials.xml', |
Preliminary version of Phase2 Timing geometry.
Dead LYSO sheet 4mm thick in the barrel just inside of the TST.
Silicon preshower in the endcaps with aluminum support.
Checked for overlaps and so far as I could tell there are none, but someone more expert than me should also check this.
Defined new sub-detector and detector configurations for phase2.
"I" for tIming layer, 1 = no timing layer, 2 = preliminary version
D5 = D3 + I2
I2 will be updated as RECO geometry is defined (right now only SIM).
Any fiducial or location changes will go into I(n+1).
Added D4 and D5 to the sim/reco geometry dumpers.