Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shunt factor in QIE11 hardcode calibrations #16082

Merged
merged 1 commit into from Oct 4, 2016

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Oct 3, 2016

The QIE11 cards will be operated with a current shunt due to the high levels of charge generated by SiPMs. The starting value of the current shunt is expected to be a factor of 6. This will be reflected in the QIE calibrations, but had been left out of the simulated values until now.

This PR updates the hardcode conditions. A separate update to the database conditions will be made by @abdoulline et al.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Oct 3, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15507/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2016

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalPlugins

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@mmusich
Copy link
Contributor

mmusich commented Oct 4, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b453b3a into cms-sw:CMSSW_8_1_X Oct 4, 2016
@slava77
Copy link
Contributor

slava77 commented Oct 4, 2016

@kpedro88
you mentioned that this is supposed to solve the high-energy hit issue.
jenkins shows no differences in 2017 workflows (including 2017HCALdev).

There are differences in 2023D3, apparently in HB part.
What's missing?

@kpedro88
Copy link
Contributor Author

kpedro88 commented Oct 4, 2016

@slava77 this solves it in the hardcode conditions, which usually aren't applied in central workflows, except for phase2. @abdoulline is preparing the associated database condition update with these values, which will fix 2017.

@slava77
Copy link
Contributor

slava77 commented Oct 4, 2016

ah, OK.
So, I wait for this then to check #15959

@abdoulline
Copy link

Kevin and Slava,

new HcalQIEData_2017_v2.0_mc has been submitted to appropriate 81X GT
queues and a request has been sent to AlCa yesterday. But it needs some
time to be propagated to GTs.

On Wed, 5 Oct 2016, Kevin Pedro wrote:

@slava77 this solves it in the hardcode conditions, which usually aren't applied in central workflows, except for
phase2. @abdoulline is preparing the associated database condition update with these values, which will fix 2017.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02gQn0dzK7ygyPaqqLlz_TcdVVzI7ks5qwtlMgaJpZM4KNJXV.gif]

@mmusich
Copy link
Contributor

mmusich commented Oct 5, 2016

@abdoulline see updated Global Tags at: #16101
This is to let people continue working on the development, everything will need to converge into a single scenario via #15994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants