Fixes and enhancements on HCAL rechit dumper #16089
Conversation
|
A new Pull Request was created by @halilg (Halil Gamsızkan) for CMSSW_8_1_X. It involves the following packages: DataFormats/HcalRecHit @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
|
@cmsbuild please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
|
unhold |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
Main code in DataFormats/HcalRecHit/test is HcalRecHitDump.cc, which is a simple
tool to dump HCAL rechits to terminal.
This pull request consists of fixes and changes made with the following purposes:
reorganized (as part of Phase 1 upgrade related SW updates)
HCAL rechits
File-by-file changes:
HcalRecHitDump.cc -- Modified rechit dumper. Code now allows the
user to pick specific rechit collections to dump, also all status bits (including
newly added ones) can be dumped with arbitrary order.
HcalRecHitDump_cfg.py (new file) -- example config which shows how
to dump HBHE rechits using identical format for both Phase 1
and legacy reconstruction. Of course, the dumped info is
incomplete because we can only compare features that coincide.
numcompare.tcl (new file) -- Poor man's "diff" replacement which knows how
to compare doubles up to certain precision. This code assumes
that compared files have the same number of lines.
print_lines.tcl (new file) -- A simple utility for picking specified lines from
text files.