Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TTreeCache for RootEmbeddedFileSequence #16091

Merged

Conversation

dan131riley
Copy link

This modifies RootEmbeddedFileSequence to have basically the same settings for the ROOT TTreeCache as the primary input file, defaulting to having the cache on. RootEmbeddedFileSequence is only used by the MixingModule, so this change will turn on caching for the MixingModule inputs without affecting any other use cases.

…mary file sequence, so input files for the MixingModule are cached
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_8_1_X.

It involves the following packages:

IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15526/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@Dr15Jones
Copy link
Contributor

@bbockelm any suggestions on how to further test this change?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit efb937e into cms-sw:CMSSW_8_1_X Oct 4, 2016
@dan131riley dan131riley deleted the ttreecache-embeddedfileseq branch October 9, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants