New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TTreeCache for RootEmbeddedFileSequence #16091
Use TTreeCache for RootEmbeddedFileSequence #16091
Conversation
…mary file sequence, so input files for the MixingModule are cached
A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_8_1_X. It involves the following packages: IOPool/Input @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@bbockelm any suggestions on how to further test this change? |
+1 |
This modifies RootEmbeddedFileSequence to have basically the same settings for the ROOT TTreeCache as the primary input file, defaulting to having the cache on. RootEmbeddedFileSequence is only used by the MixingModule, so this change will turn on caching for the MixingModule inputs without affecting any other use cases.