Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1Trigger/L1THGCal : Fix for clang compiler error undefined reference to HGCalDetId::kHGCalCellMask #16092

Merged
merged 1 commit into from Oct 7, 2016
Merged

L1Trigger/L1THGCal : Fix for clang compiler error undefined reference to HGCalDetId::kHGCalCellMask #16092

merged 1 commit into from Oct 7, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 4, 2016

Clang requires the declaration of static const variables in the .cc file where they are used.

Building edm plugin tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/libL1TriggerL1THGCalPlugins_geometries.so
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/llvm/3.8.0-dpekbn/bin/clang++ -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++14 -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Wa,--compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=uninitialized -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -DBOOST_DISABLE_ASSERTS -Wno-error=unused-variable -Wno-error=unused-variable -shared -Wl,-E -Wl,-z,defs tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/geometries/HGCalTriggerGeometryHexImp2.o tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/geometries/TrivialGeometry.o tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/geometries/NullGeometry.o tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/geometries/HGCalTriggerGeometryHexImp1.o tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/geometries/HGCalTriggerGeometryImp1.o -o tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/libL1TriggerL1THGCalPlugins_geometries.so -Wl,-E -Wl,--hash-style=gnu -L/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/a8cfa3cf46e2c655e9ea8aa18833b856/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_CLANG_X_2016-10-04-1100/lib/slc6_amd64_gcc530 -L/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/a8cfa3cf46e2c655e9ea8aa18833b856/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_CLANG_X_2016-10-04-1100/external/slc6_amd64_gcc530/lib -lL1TriggerL1THGCal -lGeometryHGCalGeometry -lGeometryCaloTopology -lGeometryCaloGeometry -lDataFormatsCaloTowers -lFWCoreFramework -lGeometryHcalCommonData -lDataFormatsCandidate -lDataFormatsEcalDetId -lDataFormatsForwardDetId -lDataFormatsGeometryVector -lDataFormatsHcalDetId -lFWCoreServiceRegistry -lDataFormatsDetId -lDataFormatsMath -lFWCoreCommon -lFWCorePythonParameterSet -lGeometryHGCalCommonData -lDataFormatsCommon -lDetectorDescriptionCore -lFWCoreParameterSet -lDataFormatsProvenance -lDetectorDescriptionExprAlgo -lDetectorDescriptionBase -lFWCoreMessageLogger -lFWCorePluginManager -lDataFormatsStdDictionaries -lFWCoreConcurrency -lFWCoreUtilities -lFWCoreVersion -lGenVector -lMathMore -lTree -lNet -lThread -lMathCore -lRIO -lboost_filesystem -lCore -lboost_python -lboost_regex -lboost_system -lpcre -lboost_thread -lboost_signals -lboost_date_time -lbz2 -lCLHEP -lgsl -lgslcblas -luuid -lpython2.7 -ltbb -lxerces-c -lz -lcms-md5 -lnsl -lcrypt -ldl -lrt -ltinyxml
tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/geometries/HGCalTriggerGeometryHexImp1.o: In function HGCalTriggerGeometryHexImp1::fillMaps(HGCalTriggerGeometryBase::es_info const&)': /build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/a8cfa3cf46e2c655e9ea8aa18833b856/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_CLANG_X_2016-10-04-1100/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryHexImp1.cc:(.text+0x17a2): undefined reference toHGCalDetId::kHGCalCellMask'
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/a8cfa3cf46e2c655e9ea8aa18833b856/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_CLANG_X_2016-10-04-1100/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryHexImp1.cc:(.text+0x1d88): undefined reference to `HGCalDetId::kHGCalCellMask'
clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation)
gmake: *** [tmp/slc6_amd64_gcc530/src/L1Trigger/L1THGCal/plugins/L1TriggerL1THGCalPlugins_geometries/libL1TriggerL1THGCalPlugins_geometries.so] Error 1
Leaving library rule at src/L1Trigger/L1THGCal/plugins

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 4, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1THGCal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @jbsauvan, @lgray this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@gartung
Copy link
Member Author

gartung commented Oct 4, 2016

@Dr15Jones

@gartung gartung changed the title Fix for clang compiler error undefined reference to HGCalDetId::kHGCalCellMask L1Trigger/L1THGCal : Fix for clang compiler error undefined reference to HGCalDetId::kHGCalCellMask Oct 4, 2016
@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15527/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

-1

Tested at: 26b2445

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16092/15527/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

@Dr15Jones
Copy link
Contributor

None of the log files for addOnTests show any obvious signs of failure.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15531/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16092/15527/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

+1
Tested at: 26b2445
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16092/15531/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16092/15531/summary.html

@davidlange6 davidlange6 merged commit 2a9f8d7 into cms-sw:CMSSW_8_1_X Oct 7, 2016
@gartung gartung deleted the L1Trigger-L1THGCal-clang-error-fix branch October 11, 2016 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @Dr15Jones @davidlange6