New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a mode of operations in which all time slices are combined #16097
Conversation
A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_8_1_X. It involves the following packages: RecoLocalCalo/HcalRecAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cvuosalo, @slava77, @davidlange6 ping for pre13 |
urgent |
+1 Adding optional new 2017 HF reco mode where all times slices are combined. By default, this new mode is disabled. There should be no change in monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-10-04-2300 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Introducing Phase 1 HF reco mode in which all time slices are combined. This is equivalent to what we did in Run 2 for cosmic runs. The timing information will be ignored.
This change is not supposed to modify any previous relvals.