Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a mode of operations in which all time slices are combined #16097

Merged
merged 1 commit into from Oct 12, 2016

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Oct 4, 2016

Introducing Phase 1 HF reco mode in which all time slices are combined. This is equivalent to what we did in Run 2 for cosmic runs. The timing information will be ignored.

This change is not supposed to modify any previous relvals.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Oct 4, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15534/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2016

@kpedro88
Copy link
Contributor

@cvuosalo, @slava77, @davidlange6 ping for pre13

@cvuosalo
Copy link
Contributor

urgent

@cvuosalo
Copy link
Contributor

+1

For #16097 fecc4a3

Adding optional new 2017 HF reco mode where all times slices are combined. By default, this new mode is disabled. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-10-04-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9b77f8f into cms-sw:CMSSW_8_1_X Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants