get rid of last remaining getByLabel calls in HLTrigger/HLTanalyzers #1611
Conversation
|
A new Pull Request was created by @perrotta for CMSSW_7_0_X. get rid of last remaining getByLabel calls in HLTrigger/HLTanalyzers It involves the following packages: HLTrigger/HLTanalyzers @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
| @@ -46,6 +38,8 @@ void EventHeader::setup(TTree* HltTree) { | |||
| HltTree->Branch("Bx", &fBx, "Bx/I"); | |||
| HltTree->Branch("Orbit", &fOrbit, "Orbit/I"); | |||
| HltTree->Branch("AvgInstDelLumi", &fAvgInstDelLumi, "AvgInstDelLumi/D"); | |||
|
|
|||
| lumi_Token = iC.consumes<LumiSummary>(edm::InputTag("lumiProducer")); | |||
There was a problem hiding this comment.
I'm afraid this is wrong, it needs to be
lumi_Token = iC.consumes<LumiSummary,edm::InLumi>(edm::InputTag("lumiProducer"));
There was a bug in the framework which didn't enforce that, but the bug is fixed and this will fail.
There was a problem hiding this comment.
Thank you Chris. I've fixed the call according to your suggestion
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
Also, this may conflict with changes on #1591 where I fixed the above mentioned problem in the previous version of the code. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Consumes migration -- Get rid of last remaining getByLabel calls in HLTrigger/HLTanalyzers
Remove the last remaining calls to getByLabel in the HLTrigger/HLTanalyzers package, also in the helper functions and their callers.