Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport edmStreamStallGrapher.py #16111

Merged

Conversation

Dr15Jones
Copy link
Contributor

Backport appropriate fixes for edmStreamStallGrapher.py from CMSSW_8_1_X. This code now properly handles the output of the Tracer in CMSSW_8_0_X.

Previously log file parser only used the first character of the stream id when converting from a string to a number. This change makes sure to get all the digits.
The algorithm for understanding the log files did not properly deal
with logs from jobs which were running unscheduled.
Use the time difference between the end of one event on a stream and the
start of the next event on a stream as an estimate for the maximum stall time
the framework could have incurred from serializing the source.
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15556/console

@Dr15Jones
Copy link
Contributor Author

+1
This is for proper diagnostics of production jobs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@Dr15Jones
Copy link
Contributor Author

This is a completely stand alone executable for which no code has any dependencies.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1fd622b into cms-sw:CMSSW_8_0_X Oct 6, 2016
@Dr15Jones Dr15Jones deleted the backportEdmStreamStallGrapher branch March 22, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants