Improve reco material code #16116
Merged
Improve reco material code #16116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simple scripts listIds* have been modified in order to be able to accept a list of materials in input, so that the user has the freedom to select which components of the tracker she wants to print, based on the material. The material name should be fully namespaced. The special keyword 'ANY' (in any location) will print all components, irrespectively of their material. Also, the special flag printMaterial will determine if the material will be printed besides the component name. All this was triggered by the fact that the material specification for the Silicon components of the PhaseII tracker do not have the same name.
The script dumpFullXML.py has been equipped with the option to derive a local trackingMaterialGroupsFromRelease.xml file reading in input the original trackingRecoMaterial.xml from a certain location in the main release tree. This is particularly useful to produce this file from scratch, i.e. when only the trackingRecoMaterial.xml has been included in release (most likely produced by some tool external to CMSSW). The values of radlen and energyloss are stripped away in the process, since they are not functional to grouping and could have only caused confusion.
Actually the file has been produced using the dumpFullXML.py script in release and then renamed and moved into the proper location.
Silen annoying messages and add the corresponding file for the PhaseII scenario. At present this is very badly handled in separate files: in future a unique approach has to be achieved via command line options (varParsing).
The script to generate neutrino gun samples to derive the reco-material map has been revised, simplified, shrinked and commented. Of particular relevance the fact that, apparently, the neutrino was not tracked any longer internally by GEANT, so the tracking has to be explicitely forced in the configuration.
|
Pull request #16116 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
|
unhold |
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update the tools needed to derive an accurate reco-material description starting from the one used in the Simulation. Support for PhaseI and PhaseII has been added, more or less transparently. Currently the PhaseII workflow will fail with an assert, a clear indication that, once again, the material description for the PhaseII detector is still wrong (due to XML reg-exp search of elements being wrong). A fix is available, but not included in this PR, that would remain pure "development".
As a possible improvement, I'd suggest to run the few shell scripts that are included in this PR either while testing every PR or as part of every PreRelease validation: this would have spotted all the problems we had for PhaseI and still have for PhaseII immediately.