Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper use of eras for L1Reco and a fastSim fix #16118

Merged
merged 2 commits into from Oct 8, 2016
Merged

Proper use of eras for L1Reco and a fastSim fix #16118

merged 2 commits into from Oct 8, 2016

Commits on Oct 6, 2016

  1. properly use eras with l1extraParticles 

    Moved the era modifications of l1extraParticles from
L1Trigger.Configuration.L1TReco_cff to here where they are meant
to be.
The default parameters for l1extraParticles now match the legacy trigger
values used in L1TReco_cff.
    @Dr15Jones
    Dr15Jones committed Oct 6, 2016
    Copy the full SHA
    9761971 View commit details
    Browse the repository at this point in the history

  2. Modernized use of eras and fixed problem with fastSim configuration 

    The 'isChosen' interface is deprecated for Modifiers so needed to
be replaced with with modern recommended usage for eras.

The module l1L1GtObjectMap never worked properly when run in fastSim
since it needed data from a module which was run in a later Path.
The result was the data from l1L1GtObjectMap was never put into the
event for fastSim. Now that the framework is going to run Paths
in parallel, the improper data dependency is producing an unrunnable
schedule. Therefore remove the module from the Sequence gives
functionally equivalent behavior as before this change.
    @Dr15Jones
    Dr15Jones committed Oct 6, 2016
    Copy the full SHA
    c40cda6 View commit details
    Browse the repository at this point in the history