Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making averageDigiOccupancy threadsafe in offline. #16138

Merged
merged 2 commits into from Oct 13, 2016

Conversation

leggat
Copy link
Contributor

@leggat leggat commented Oct 7, 2016

It is now (in offine only) a TH1 that is normalised in the dqmEndJob step of the SiPixelEDAClient. These changes do not affect online implementation.

…ine only) a TH1 that is normalised in the dqmEndJob step of the SiPixelEDAClient. These changes do not affect online implementation.
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

A new Pull Request was created by @leggat for CMSSW_8_1_X.

It involves the following packages:

DQM/SiPixelMonitorClient
DQM/SiPixelMonitorDigi

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

This was referenced Oct 7, 2016
@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15654/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 49efd62 into cms-sw:CMSSW_8_1_X Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants