Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qie11 task 81x #16142

Merged
merged 2 commits into from Oct 11, 2016
Merged

Add qie11 task 81x #16142

merged 2 commits into from Oct 11, 2016

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Oct 7, 2016

add QIE11 task to the hcal calibration application.
same as #16141

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 7, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_8_1_X.

It involves the following packages:

DQM/HcalTasks
DQM/Integration

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15602/console

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15624/console

@cmsbuild
Copy link
Contributor

+1
Tested at: be193d5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16142/15624/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16142/15624/summary.html

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

dmitrijus
dmitrijus reviewed Oct 11, 2016
View reviewed changes
DQM/HcalTasks/plugins/QIE11Task.cc
{
if (_ptype!=fOnline || _laserType < 0)
return true;
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you don't use {} for the first block, don't use it for the else-block either. It looks rather confusing....

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bb19d18 into cms-sw:CMSSW_8_1_X Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrijus dmitrijus dmitrijus left review comments

Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deguio @cmsbuild @kpedro88 @dmitrijus @davidlange6