Remove old FPIX; make New FPIX default, and update FPIX materials #16149
Conversation
|
A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @monttj, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
Just thinking out loud: if this cleanup is not strictly needed for 81X, how about postponing it to 90X? In case of problems we would have more time to fix. |
|
Hi @makortel - I don't agree with leaving this mess around for 8_1_0 (or later). Its not good that we've coupled cleanup and real changes. It would be far easier to do things one by one... |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Hi @schneiml - could you rebase. thx |
Some _cfg.py might be still broken. Some conflicts needed to be fixed. 2017NewFPix left in place, identical to 2017 up to conflicts.
…IX and FPIX (untested)
It did not reflect the actual 2017 pixel and the name is confusing.
It should not be needed any more. This finally removes the old phase1 FPIX xml files. (Some copies still exist for phase2).
schneiml
force-pushed
the
pixfwd-remove-old-fpix-add-material-description-update
branch
from
919315f
to
4d5c330
Compare
cmsbuild
added
comparison-pending
geometry-pending
tests-pending
and removed
comparison-available
geometry-approved
tests-approved
labels
|
Pull request #16149 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @monttj, @cmsbuild, @davidlange6 can you please check and sign again. |
|
Rebased. The original idea was to merge this instead of #16148 , and I added that commit in here... Anyways, rebased now, all relevant files stay identical. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
This PR is #15986 + #16148 .
Remove old FPIX; make New FPIX default (RFC) #15986 can still be disputed; in that case only Updated xml description of forward pixels #16148 should be merged. But if we want both changes in, this is the PR to use.
(also @tmulholland , @veszpv , @friccita )