FixZeroOccupancyOnline #16154
FixZeroOccupancyOnline #16154
Conversation
|
A new Pull Request was created by @fioriNTU for CMSSW_8_0_X. It involves the following packages: DQM/SiPixelMonitorDigi @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@dmitrijus can you please start the tests, would be great to have this integrated in the next Online release if possible |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
You have to make and merge 81x version of it first, you know the drill. |
|
@dmitrijus ok, I will do it asap, I was not sure since this PR has impact only in Online DQM and the "Phase 0" DQM will be completely superseeded by the Pahse I at the beginning of 2017 |
cmsbuild
added
comparison-pending
dqm-pending
pending-signatures
tests-pending
and removed
dqm-approved
fully-signed
tests-approved
labels
|
Pull request #16154 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Sorry, I found another minor bug here, the plots were filled with a bin in advance ... I will add again to the tag collector even if it is not so urgent now |
|
You need to get into 81x - I guess another PR and link it here. |
|
found it: #16199 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
This PR fix the Pixel zero occupancy rocs plots in Online DQM
The plots where broken by the switch to multithread in Offline
The fix is not very elegant but it works, the logic of the previous code was completely wrong: for each module zero occupancy rocs in the full shell/half cylinder where added up, now they are counted only once each 10 lumisections
Since these plots are produced only in Online DQM I am not sure if I should make the same PR in 81X, please let me know.