Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing AlcaRecos in 2017 WFs #16168

Merged
merged 1 commit into from Oct 12, 2016
Merged

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Oct 11, 2016

This PR aims to introduce the Alcareco steps (as in run 2 MC) .
It is important to introduce the alcareco in view of MC prodcution, in particular for alignment

One comment :
There is one difference with respect to the alca steps for run2 Wfs .
I removed EcalTrg from the alca path which is crashing - Maybe this can be looked later on.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@boudoul
Copy link
Contributor Author

boudoul commented Oct 11, 2016

@mmusich , @franzoni , you may want to take a look to this PR - Thanks

@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15641/console

@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2016

about:

One comment :
There is one difference with respect to the alca steps for run2 Wfs .
I removed EcalTrg from the alca path which is crashing - Maybe this can be looked later on.

needs an update of the phase-I GT, but it's a level of sophistication we don't need at this moment in time.

@@ -1765,6 +1766,20 @@ def lhegensim(fragment,howMuch):
upgradeStepDict['HARVESTFull_trackingOnlyPU'][k]=merge([PUDataSets[k2],upgradeStepDict['HARVESTFull_trackingOnly'][k]])
upgradeStepDict['HARVESTFullGlobalPU'][k]=merge([PUDataSets[k2],upgradeStepDict['HARVESTFullGlobal'][k]])



upgradeStepDict['ALCAFull'][k] = {'-s':'ALCA:TkAlMuonIsolated+TkAlMinBias+MuAlOverlaps+EcalESAlign',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda @kpedro88 anything Hcal related you might want to be included in here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda should comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to add HcalCalHBHEMuonFilter to this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boudoul would you mind adding the request from Sunanda? as I understand this doens't lie anymore in the critical path for pre13..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, will update later tonight - thanks for the prompt feedback !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been merged before I could modified it, so the request for the new alcareco is addressed in a new PR #16183

@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2016

thanks @boudoul !

@cmsbuild
Copy link
Contributor

@fabozzi
Copy link
Contributor

fabozzi commented Oct 11, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants