Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Resonance Decay Filter #16171

Conversation

DavidMorse
Copy link
Contributor

Backporting pull request #15285 to 80X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @DavidMorse (David Morse) for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15799/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 250f1f3

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16171/15799/summary.html

I found follow errors while testing this PR

Additional comment: materialbudget
Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error
140.53 step1
DAS Error
1003.0 step1
DAS Error

@DavidMorse
Copy link
Contributor Author

Hi, I'm not an expert in debugging this, but looking through the tests the only error I can find is:

IOError: [Errno 2] No such file or directory: 'das-cache.file'

and it only happens on data workflows. It seems unlikely that any of the changes could have caused this, particularly since they should only be accessed during GEN-SIM. But maybe I am missing something...

@perrozzi
Copy link
Contributor

Hi @DavidMorse, I agree that the error seems unrelated, the PR should be ready to be merged, re-approving

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@perrozzi
Copy link
Contributor

perrozzi commented Nov 1, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16119/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@perrozzi
Copy link
Contributor

@DavidMorse this can be incorporated, right?

@DavidMorse
Copy link
Contributor Author

@perrozzi Yes, good to go.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bc966a2 into cms-sw:CMSSW_8_0_X Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants