New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Resonance Decay Filter #16171
Updates to Resonance Decay Filter #16171
Conversation
A new Pull Request was created by @DavidMorse (David Morse) for CMSSW_8_0_X. It involves the following packages: GeneratorInterface/Pythia8Interface @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 250f1f3 You can see the results of the tests here: I found follow errors while testing this PR Additional comment: materialbudget
When I ran the RelVals I found an error in the following worklfows: DAS Error140.53 step1 DAS Error1003.0 step1 DAS Error |
Hi, I'm not an expert in debugging this, but looking through the tests the only error I can find is: IOError: [Errno 2] No such file or directory: 'das-cache.file' and it only happens on data workflows. It seems unlikely that any of the changes could have caused this, particularly since they should only be accessed during GEN-SIM. But maybe I am missing something... |
Hi @DavidMorse, I agree that the error seems unrelated, the PR should be ready to be merged, re-approving |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@DavidMorse this can be incorporated, right? |
@perrozzi Yes, good to go. |
+1 |
Backporting pull request #15285 to 80X