Puppi isolation miniAOD electrons & photons v2

[ishvetso]

PUPPI isolation for electrons and photons for miniAOD.
this is a rebase of #16055

[cmsbuild]

Pull request #16172 was updated. @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15803/console

[cmsbuild]

+1
Tested at: a454efc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16172/15803/summary.html
Additional comment: 'materialbudget'

[slava77]

+1

for #16172 af5583c

• code changes are in line with the PR description and the follow up code review. For miniAOD electrons 6 new isolation floats are added and 3 new floats are added for photons.
• jenkins tests pass and comparisons with baseline show no differences as expected (based on previous commit tests)
• local tests with 1000 ttbar PU35 events show that new variables are filled with somewhat reasonable distributions for isolations. On the technical side:
  • the event size increased by 55 bytes/evt in slimmedPhotons and slimmedElectrons (with a few bytes of compression noise) or by 0.1%;
  • egmPhotonPUPPIIsolationForPhotons module is gone to be replaced by egmElectronPUPPIIsolation, egmElectronPUPPINoLeptonsIsolation, and egmPhotonPUPPIIsolation for a net increase in CPU time of about 3 ms/evt (0.15% of miniAOD processing time).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16172/15803/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
• 22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimHLBeamSpotFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing

[monttj]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1