Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of conddb console output #16187

Merged
merged 1 commit into from Oct 18, 2016

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Oct 12, 2016

When a multi-line field is printed on the console, the output
is severely compromised, to the point of being non-readable.
The problem is due to the non correct handling of
line-breaks. This PR cures the problem using native str
methods. The special character '+' has been used to indicate
that the original field was a multi-line field. The choice
was completely arbitrary. Limited testing has been
performed, but on the pathological case, the correct
behaviour is restored. To test use, e.g.:
*

  • conddb search SiStripDQMTrigger
    *
    before and after this patch.

When a multi-line field is printed on the console, the output
is severely compromised, to the point of being non-readable.
The problem is due to the non correct handling of
line-breaks. This PR cures the problem using native str
methods. The special character '+' has been used to indicate
that the original field was a multi-line field. The choice
was completely arbitrary. Limited testing has been
performed, but on the pathological case, the correct
behaviour is restored. To test use, e.g.:
*
* conddb search SiStripDQMTrigger
*
before and after this patch.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_8_1_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ggovi
Copy link
Contributor

ggovi commented Oct 17, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15771/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16187/15771/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
  • 22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimHLBeamSpotFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing

@ggovi
Copy link
Contributor

ggovi commented Oct 17, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 05ca46e into cms-sw:CMSSW_8_1_X Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants