BugFix for PseudoTop construction in dilepton channel using proper lepton charges

[msavitskyi]

The bugfix needed to avoid cases, when Top Quark/ W-Plus / Anti-Lepton / B-jet are filled with charge/PdgIds corresponding to respective anti-particles (and vice versa), while keeping the original four-vectors (as associated to particular lepton). After the occurrence of such cases, an object collection (let's say, Anti-Leptons) actually is a mix of true Anti-Leptons and fakes from true Leptons (opposite for original Leptons collection). More detailed explanation of code's performance without bugfix is given in HN message "1" as indicated below, while message "2" leads to performance plots before/after bugfix.

Please check these messages on the HyperNews:

1. https://hypernews.cern.ch/HyperNews/CMS/get/top/2302/1/2/1.html
2. https://hypernews.cern.ch/HyperNews/CMS/get/top/2302/1/2/1/1.html
3. https://hypernews.cern.ch/HyperNews/CMS/get/top/2302/1/2/1/1/1.html

[cmsbuild]

A new Pull Request was created by @msavitskyi for CMSSW_8_1_X.

It involves the following packages:

TopQuarkAnalysis/TopEventProducers

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[monttj]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15703/console

[cmsbuild]

+1
Tested at: 4620f07
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16190/15703/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16190/15703/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix
• 10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev
• 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew

[monttj]

+1
It is straightforward. The bug for charge flip was fixed by re-defining the charge.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1