Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial additions to SIM #16192

Merged
merged 2 commits into from Oct 13, 2016
Merged

Trivial additions to SIM #16192

merged 2 commits into from Oct 13, 2016

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Oct 12, 2016

Added:

  • possibility to dump several gdml files in one test run;
  • extra comments to script which check overlaps and dump gdml
  • default check is for Tracker2017
  • script to TB2006 test-beam run

This PR will not affect any real work flow and SIM production.

@civanch civanch changed the title Trivial addition to SIM Trivial additions to SIM Oct 12, 2016
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 12, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_8_1_X.

It involves the following packages:

SimG4CMS/HcalTestBeam
SimG4Core/Geometry

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor Author

civanch commented Oct 12, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15692/console

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor Author

civanch commented Oct 12, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16192/15692/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
  • 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
  • 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix
  • 10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev
  • 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1b31dae into cms-sw:CMSSW_8_1_X Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants