New seeding framework #16202

makortel · 2016-10-13T11:31:48Z

Despite of submitting this PR to 81X, this PR really targets (early) 90X (I'm submitting it now in the hope of gaining more time for the review in case L2s would have time to look already now).

This PR provides a new way to plug the seeding code to CMSSW. It takes the TrackingRegion creation, cluster number check, and doublet/triplet/quadruplet generation out of the seed generator, and makes each of them an EDProducer. The regions, decision of the cluster number check, and the hit doublets/triplets are delivered to subsequent components via edm::Event.

The implementation is fully backwards compatible, i.e. all existing configurations should work out of the box. Instances of SeedGeneratorFromRegionHitsEDProducer can be migrated one at a time. Here the offline iterative tracking is fully migrated (including, with minimal effort, knock-on effects in FastSim and HI), but nothing else (e.g. HLT) is not (yet).

Pros

Much more flexibility in interfaces (not more constrained by "common denominator")
fillDescriptions fully supported
For PixelQuadrupletGenerator, removes repetitive doublet generation of certain layer pairs
For CAHit*Generator
- Allows fast regional ntuplet finding
  - No need to do everything per region, but fill CA from all doublets and find ntuplets for all regions simultaneously on one go
- Allows (easily) to put (e.g.) quadruplets and triplets, found simulateneously on one go, to Event as separate collections
  - Can be exploited to reduce repetitive hit triplet generation between iterations
Allows "medium-grained" parallelization
Opens further optimization possibilities

Cons

Additional data structures to deliver information between modules
More modules to manage in configuration

Subsequent steps

Do similar transformation to PixelTrackProducer
- Additional complication from adding fillDescriptions support for fitter, filter, and cleaner
Migrate all seeding and pixel track modules in HLT (in customizeHLTforCMSSW.py)

Expected effect

Tested in CMSSW_8_1_X_2016-10-04-1100 (rebased on top of CMSSW_8_1_X_2016-11-08-2300), no changes expected in monitored quantities. The expected speedup in 10224 (2017 ttbar+PU) seeding is ~2-3 %. The expected memory increase is ~10 MB (based on IgProf LIVE, SimpleMemoryCheck on 6 threads gives similar order of magnitude although across-event variations are larger).

@rovere @VinInn @mtosi @felicepantaleo

cmsbuild · 2016-10-13T11:32:11Z

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/TrackerRecHit2D
FastSimulation/Tracking
RecoHI/HiMuonAlgos
RecoHI/HiTracking
RecoMuon/GlobalTrackingTools
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTriplets
RecoTauTag/HLTProducers
RecoTracker/Configuration
RecoTracker/ConversionSeedGenerators
RecoTracker/IterativeTracking
RecoTracker/SpecialSeedGenerators
RecoTracker/TkHitPairs
RecoTracker/TkSeedGenerator
RecoTracker/TkSeedingLayers
RecoTracker/TkTrackingRegions
TrackingTools/TransientTrackingRecHit
Validation/RecoTrack

@perrotta, @cmsbuild, @civanch, @lveldere, @silviodonato, @cvuosalo, @fwyzard, @ssekmen, @mdhildreth, @dmitrijus, @Martin-Grunewald, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @abbiendi, @echapon, @dgulhan, @battibass, @jhgoh, @amagitte, @HuguesBrun, @trocino, @yetkinyilmaz, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @wmtford, @mschrode, @richard-cms, @Martin-Grunewald, @mandrenguyen, @MiheeJo, @jazzitup, @calderona, @yenjie, @kurtejung, @gpetruc, @matt-komm, @rociovilar, @bachtis this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

makortel · 2016-10-13T11:35:27Z

I'm not very happy with the use of edm::OwnVector for storing TrackingRegions (vector<unique_ptr<T>> would have been enough), but it was the easiest to use.

I also feel that at some point we might want/need to move the transient data products to better package(s) instead of scattering them around (even if the latter appears to work in practice).

VinInn · 2016-10-13T11:37:49Z

I undestood that for transient products any c++ class can be used vector<unique_ptr<T>> as well.

VinInn · 2016-10-13T11:38:52Z

@cmsbuild , please test

makortel · 2016-10-13T11:48:59Z

In practice it turned out that dictionary generation for vector<unique_ptr<TrackingRegion> > failed because deleted copy constructor, and vector<shared_ptr<TrackingRegion> > didn't work because framework gives runtime exception of

Class name 'TrackingRegionstdshared_ptrs' contains an underscore ('_'), which is illegal in the name of a product.

Of course either can be worked out in several ways, but (when still unsure if this direction of development was feasible), I chose edm::OwnVector because of minimal effort.

In subsequent development I'm actually already using the same pattern we have for
track<->TrackingParticle associators
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/SimDataFormats/Associations/interface/TrackToTrackingParticleAssociator.h
I could do the same here (but maybe in a separate or 90X PR).

cmsbuild · 2016-10-14T05:16:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15722/console

cmsbuild · 2016-10-14T06:19:17Z

-1

Tested at: 37a21ea

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16202/15722/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

10021.0 step3

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

20024.0 step3

runTheMatrix-results/20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10624.0 step3

runTheMatrix-results/10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew.log

10424.0 step3

runTheMatrix-results/10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

22424.0 step3

runTheMatrix-results/22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Fri Oct 14 08:06:52 2016-date Fri Oct 14 08:06:48 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:18:07 2016-date Fri Oct 14 08:06:54 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:11:14 2016-date Fri Oct 14 08:06:58 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:13:21 2016-date Fri Oct 14 08:07:02 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Fri Oct 14 08:07:07 2016-date Fri Oct 14 08:07:04 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:12:45 2016-date Fri Oct 14 08:07:09 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Oct 14 08:07:14 2016-date Fri Oct 14 08:07:11 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:11:11 2016-date Fri Oct 14 08:07:13 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:11:58 2016-date Fri Oct 14 08:07:14 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:13:11 2016-date Fri Oct 14 08:07:19 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:11:52 2016-date Fri Oct 14 08:07:24 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:09:22 2016-date Fri Oct 14 08:07:30 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:12:42 2016-date Fri Oct 14 08:07:33 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:08:24 2016-date Fri Oct 14 08:07:37 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Oct 14 08:13:32 2016-date Fri Oct 14 08:07:40 2016 s - exit: 256

cmsbuild · 2016-10-14T08:15:45Z

Pull request #16202 was updated. @perrotta, @cmsbuild, @civanch, @lveldere, @silviodonato, @cvuosalo, @fwyzard, @ssekmen, @mdhildreth, @dmitrijus, @Martin-Grunewald, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

makortel · 2016-10-14T08:17:46Z

I had missed this "old-style era usage" while rebasing, and my local tests succeeded nevertheless because my local area did not contain #16086 (which removed the import of Eras.py).

VinInn · 2016-10-14T08:18:26Z

@cmsbuild , please test

cmsbuild · 2016-10-14T08:18:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15727/console

slava77 · 2016-11-16T22:11:31Z

-1

moved to 90X

…gerEDProducer

…ionsOffline()

… testRegionalMuonTracking_cfg.py as obsolete

I believe the cleanup of cust_2023tilted and the integration of D6 interleaved or something.

…lows

cmsbuild · 2016-11-17T14:38:44Z

Pull request #16202 was updated. @perrotta, @cmsbuild, @civanch, @lveldere, @dmitrijus, @silviodonato, @cvuosalo, @fwyzard, @ssekmen, @mdhildreth, @fabozzi, @Martin-Grunewald, @srimanob, @slava77, @vanbesien, @hengne, @davidlange6 can you please check and sign again.

makortel · 2016-11-17T14:40:07Z

Closed in favor of 90X (#16635).

cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 13, 2016

cmsbuild added comparison-pending dqm-pending fastsim-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 13, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 13, 2016

cmsbuild added tests-pending and removed tests-started labels Oct 14, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2016

cmsbuild added tests-rejected tests-pending and removed tests-started tests-rejected labels Oct 14, 2016

cmsbuild mentioned this pull request Nov 16, 2016

New seeding framework #16635

Merged

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Nov 16, 2016

makortel added 16 commits November 17, 2016 09:11

Put temporary TrajectorySeedCollection to event in PixelQuadrupletMer…

90c35e0

…gerEDProducer

Add explicit UseVertex=True

8c6c4b2

Rename MuonTrackingRegionBuilder::fillDescriptions2() to fillDescript…

bd3eb4f

…ionsOffline()

Change exception categories to LogicError

cd0aebe

Add line breaks

6e54cc3

Move era customizations to _cfi's

1d51a83

Migrate FastSim to read TrackingRegions from Event

caad90e

Migrate customiseClusterCheckForHighPileup.py

79cbe5c

Migrate peripheralPbPb era customizations

fe1e60f

Remove commented unnecessary config

c417003

Remove newline

65731cf

Remove HiRegitMuonLowPtTripletStep_cff, HiRegitMuonTobTecStep_cff and…

dd60908

… testRegionalMuonTracking_cfg.py as obsolete

Remove HiTrackingRegionFactoryFromSTAMuonsBlock as obsolete

e3ce97f

Add customize function to early-delete new temporary data products

21b7a97

Remove obsolete customize from D6 workflows

a514a5a

I believe the cleanup of cust_2023tilted and the integration of D6 interleaved or something.

Enable customiseEarlyDeleteForSeeding for all phase1 and phase2 workf…

bdff194

…lows

cmsbuild added comparison-pending pdmv-pending reconstruction-pending tests-pending and removed comparison-available reconstruction-rejected tests-approved labels Nov 17, 2016

makortel closed this Nov 17, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New seeding framework #16202

New seeding framework #16202

makortel commented Oct 13, 2016 •

edited

cmsbuild commented Oct 13, 2016

makortel commented Oct 13, 2016

VinInn commented Oct 13, 2016 •

edited

VinInn commented Oct 13, 2016

makortel commented Oct 13, 2016

cmsbuild commented Oct 14, 2016 •

edited

cmsbuild commented Oct 14, 2016

cmsbuild commented Oct 14, 2016

makortel commented Oct 14, 2016

VinInn commented Oct 14, 2016

cmsbuild commented Oct 14, 2016 •

edited

slava77 commented Nov 16, 2016

cmsbuild commented Nov 17, 2016

makortel commented Nov 17, 2016

New seeding framework #16202

New seeding framework #16202

Conversation

makortel commented Oct 13, 2016 • edited

Pros

Cons

Subsequent steps

Expected effect

cmsbuild commented Oct 13, 2016

makortel commented Oct 13, 2016

VinInn commented Oct 13, 2016 • edited

VinInn commented Oct 13, 2016

makortel commented Oct 13, 2016

cmsbuild commented Oct 14, 2016 • edited

cmsbuild commented Oct 14, 2016

cmsbuild commented Oct 14, 2016

makortel commented Oct 14, 2016

VinInn commented Oct 14, 2016

cmsbuild commented Oct 14, 2016 • edited

slava77 commented Nov 16, 2016

cmsbuild commented Nov 17, 2016

makortel commented Nov 17, 2016

makortel commented Oct 13, 2016 •

edited

VinInn commented Oct 13, 2016 •

edited

cmsbuild commented Oct 14, 2016 •

edited

cmsbuild commented Oct 14, 2016 •

edited