Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove false dependency to TrackingTools/PatternTools. #16220

Merged
merged 1 commit into from Oct 18, 2016

Conversation

alja
Copy link
Contributor

@alja alja commented Oct 14, 2016

I noticed this when building cmsShow tarball.

@alja
Copy link
Contributor Author

alja commented Oct 14, 2016

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/EgammaTrackReco

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Oct 15, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15755/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #16220 9f4a4a2

Removing false dependency from DataFormats/EgammaTrackReco BuildFile.xml. There should be no change in compiled output.

Jenkins tests against baseline CMSSW_8_1_X_2016-10-14-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ca844ae into cms-sw:CMSSW_8_1_X Oct 18, 2016
@alja alja deleted the from-CMSSW_8_1_0_pre12 branch May 11, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants