Rho 8_0_X backport of PR 15233 #16236

yetkinyilmaz · 2016-10-17T22:29:38Z

8_0_X version of the earlier merged PR #15233
Identical commits, only backported to 8_0_X.

SCRAM_ARCH=slc6_amd64_gcc530
CMSSW_8_0_X_2016-10-16-0000
runTheMatrix.py -s

10 10 9 7 5 1 1 1 tests passed, 0 0 0 0 0 0 0 0 failed

cmsbuild · 2016-10-17T22:29:56Z

A new Pull Request was created by @yetkinyilmaz for CMSSW_8_0_X.

It involves the following packages:

RecoHI/Configuration
RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@yslai, @MiheeJo, @jazzitup, @richard-cms, @echapon, @yenjie, @kurtejung, @mandrenguyen, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

yetkinyilmaz · 2016-10-18T10:20:41Z

@slava77 can you trigger the tests so that the PR progresses?
Thanks.

yetkinyilmaz · 2016-10-18T10:22:17Z

Workflow 281 also tested and passed (on CMSSW_8_0_X_2016-10-16-0000 in which run2 workflow is defined).

slava77 · 2016-10-18T12:36:39Z

@cmsbuild please test

cmsbuild · 2016-10-18T12:36:54Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15787/console

cmsbuild · 2016-10-18T13:41:47Z

+1
Tested at: 818fbc3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16236/15787/summary.html
Additional comment: 'materialbudget'

cmsbuild · 2016-10-18T14:57:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16236/15787/summary.html

slava77 · 2016-10-19T17:54:14Z

merge conflicts are present here
@yetkinyilmaz please update the PR description as well (it says "Needed for the approval of #16120", but that PR is merged already)

cvuosalo · 2016-10-19T21:46:52Z

urgent

cvuosalo · 2016-10-19T21:49:12Z

@yetkinyilmaz: Please fix the merge conflicts as soon as you can. Once those are fixed and Jenkins tests are run, this PR can be approved.

cmsbuild · 2016-10-20T02:44:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15843/console

cmsbuild · 2016-10-20T05:14:22Z

+1
Tested at: 02b98ea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16236/15843/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
02b98ea
9a75ea5
ba23892
c887036
6ee7f2c
55ff5c6
542ca39
93f2407
8a17d10
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16236/15843/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16236/15843/git-merge-result

cmsbuild · 2016-10-20T05:14:25Z

Comparison job queued.

slava77 · 2016-10-20T05:48:47Z

@cvuosalo
this should be tested with customisePPrecoforPPb for signoff.
I'm guessing, a basic 136.731 or similar is a good workflow to start from.

mandrenguyen · 2016-10-20T05:56:20Z

@slava77 @cvuosalo wf 281 now includes the customize

slava77 · 2016-10-20T05:59:50Z

@mandrenguyen
thanks.
Is there a wf with forPbPb ?

mandrenguyen · 2016-10-20T06:03:30Z

@slava77 Ah, good point. For running the pp reco on peripheral PbPb I don't believe we have a relval wf. Could be added. In the meantime, just changing customisePPrecoforPPb to customisePPrecoForPeripheralPbPb, will have to suffice.

cmsbuild · 2016-10-20T07:14:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16236/15843/summary.html

The workflows 1003.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

cvuosalo · 2016-10-20T12:25:04Z

backport #15233

cvuosalo · 2016-10-20T12:30:18Z

@slava77: Are the tests of this 80X version of this PR so essential that we should leave this PR out of 8_0_21, which is about to be built? The same tests were already performed for the 81X version of this PR, as discussed here: #15233. I think I will leave the decision to David. I will approve, start the tests, and report the results when they are available.

yetkinyilmaz · 2016-10-20T12:36:26Z

Just to note, it is tested privately with the following (including wf 281), both before and after yesterday's update.

export SCRAM_ARCH=slc6_amd64_gcc530
scram p CMSSW CMSSW_8_0_X_2016-10-16-0000
cd CMSSW_8_0_X_2016-10-16-0000/src
eval scram ru -sh
git cms-merge-topic yetkinyilmaz:rho_80X_01
scram b

runTheMatrix.py -l 281
runTheMatrix.py -s

cvuosalo · 2016-10-20T12:41:00Z

+1

For #16236 02b98ea

Adding a Heavy Ion pPb customization to include a rho analyzer and empty area correction. The customization is not used by default. There should be no change in monitored quantities.

#15233 is the 81X version of this PR, and it has already been merged.

The code changes match those in #15233, and Jenkins tests against baseline CMSSW_8_0_X_2016-10-18-2300 show no significant differences, as expected, but DQM comparison results are not available. Additional tests were performed for #15233, including testing the new customization, and they show no problems.

Further tests of this PR are underway, but it has been approved provisionally to allow it to be included in 8_0_21.

cmsbuild · 2016-10-20T12:41:14Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

slava77 · 2016-10-20T12:52:34Z

On 10/20/16 5:30 AM, Carl Vuosalo wrote:

@slava77 https://github.com/slava77: Are the tests of this 80X version
of this PR so essential
that we should leave this PR out of 8_0_21,
which is about to be built?

yes, considering that 8_0_21 build has started more than 20 hours ago

The same tests were already performed for
the 81X version of this PR, as discussed here: #15233
#15233. I think I will leave the
decision to David. I will approve, start the tests, and report the
results when they are available.

thanks in advance for checking the test results.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16236 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbprpX31gaefT3yPAC5Nc8JzGw4vDks5q117bgaJpZM4KZLhB.

davidlange6 · 2016-10-20T14:35:05Z

+1

cvuosalo · 2016-10-27T22:28:48Z

A test of workflow 281.0_EPOS_PPb with 20 events against baseline CMSSW_8_0_21 shows no significant differences, as does a test of this workflow with customization customisePPrecoForPeripheralPbPb. The former test shows the expected rho additions to event content:

-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
      0.0 ->       190.9        191     NEWO   0.04     doubles_hiFJGridEmptyAreaCalculator_mapToRhoCorr_RECO.
      0.0 ->       126.4        126     NEWO   0.03     doubles_hiFJRhoProducer_mapEtaEdges_RECO.
      0.0 ->       135.2        135     NEWO   0.03     doubles_hiFJGridEmptyAreaCalculator_mapEmptyCorrFac_RECO.
      0.0 ->       193.2        193     NEWO   0.04     doubles_hiFJGridEmptyAreaCalculator_mapToRhoMCorr_RECO.
      0.0 ->       161.1        161     NEWO   0.04     doubles_hiFJRhoProducer_mapToRho_RECO.
      0.0 ->       202.9        203     NEWO   0.04     doubles_hiFJGridEmptyAreaCalculator_mapToRhoCorr1Bin_RECO.
      0.0 ->       317.1        317     NEWO   0.07     doubles_hiFJRhoProducer_areaJets_RECO.
      0.0 ->       490.4        490     NEWO   0.11     doubles_hiFJRhoProducer_ptJets_RECO.
      0.0 ->       201.4        201     NEWO   0.04     doubles_hiFJGridEmptyAreaCalculator_mapToRhoMCorr1Bin_RECO.
      0.0 ->       182.4        182     NEWO   0.04     doubles_hiFJRhoProducer_mapToRhoM_RECO.
      0.0 ->       534.9        535     NEWO   0.12     doubles_hiFJRhoProducer_etaJets_RECO.
-------------------------------------------------------------
   454124 ->      456902       2778             0.6     ALL BRANCHES

dgulhan added 6 commits October 17, 2016 23:20

rho analyzer

54c1822

initialization added obsolete comments removed

9339799

changed auto_ptr

02aa9a1

changed to unique_ptr

d4b8369

rho producer

f6b9af6

clone kt4 jets

818fbc3

cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 17, 2016

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 17, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 18, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 18, 2016

cmsbuild added the urgent label Oct 19, 2016

merge the customize function

02b98ea

cmsbuild added tests-started and removed tests-pending labels Oct 20, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 20, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 20, 2016

cmsbuild added the backport label Oct 20, 2016

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Oct 20, 2016

cmsbuild added orp-approved and removed orp-pending labels Oct 20, 2016

cmsbuild merged commit 5f38639 into cms-sw:CMSSW_8_0_X Oct 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rho 8_0_X backport of PR 15233 #16236

Rho 8_0_X backport of PR 15233 #16236

yetkinyilmaz commented Oct 17, 2016 •

edited

cmsbuild commented Oct 17, 2016

yetkinyilmaz commented Oct 18, 2016

yetkinyilmaz commented Oct 18, 2016

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 •

edited

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 19, 2016

cvuosalo commented Oct 19, 2016

cvuosalo commented Oct 19, 2016

cmsbuild commented Oct 20, 2016 •

edited

cmsbuild commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

slava77 commented Oct 20, 2016

mandrenguyen commented Oct 20, 2016

slava77 commented Oct 20, 2016

mandrenguyen commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

cvuosalo commented Oct 20, 2016

cvuosalo commented Oct 20, 2016

yetkinyilmaz commented Oct 20, 2016

cvuosalo commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

slava77 commented Oct 20, 2016

davidlange6 commented Oct 20, 2016

cvuosalo commented Oct 27, 2016

Rho 8_0_X backport of PR 15233 #16236

Rho 8_0_X backport of PR 15233 #16236

Conversation

yetkinyilmaz commented Oct 17, 2016 • edited

cmsbuild commented Oct 17, 2016

yetkinyilmaz commented Oct 18, 2016

yetkinyilmaz commented Oct 18, 2016

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 • edited

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 19, 2016

cvuosalo commented Oct 19, 2016

cvuosalo commented Oct 19, 2016

cmsbuild commented Oct 20, 2016 • edited

cmsbuild commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

slava77 commented Oct 20, 2016

mandrenguyen commented Oct 20, 2016

slava77 commented Oct 20, 2016

mandrenguyen commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

cvuosalo commented Oct 20, 2016

cvuosalo commented Oct 20, 2016

yetkinyilmaz commented Oct 20, 2016

cvuosalo commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

slava77 commented Oct 20, 2016

davidlange6 commented Oct 20, 2016

cvuosalo commented Oct 27, 2016

yetkinyilmaz commented Oct 17, 2016 •

edited

cmsbuild commented Oct 18, 2016 •

edited

cmsbuild commented Oct 20, 2016 •

edited