New template one::EDAnalyzer for dealing with B ON/OFF transitions using EventSetup and PoolDBOutputService. #16248

diguida · 2016-10-18T13:51:13Z

This code enables to automatically handle condition changes in case of magnetic field transitions using EventSetup via GlobalTag, and PoolDBOutputService. It was developed during 2015.

The new analyzer requires as template arguments:

the payload class
the associated Record

It grabs the whole information using the GlobalTag at endRun:

it retrieves the value of the magnet current from the product delivered by RunInfoRcd
it compares the average current with the threshold set by the user in the configuration
it loads the payload from the target tag and the reference payload using the labels of the target Record: the target tag is associated to the empty (default) label, the reference tag is chosen from the label corresponding to B ON or B OFF according to the comparison of the above step
it compares the current payload and the reference payload using an abstract method whose implementation is left to endusers, as they know how to assess whether or not two condition payloads are the same
if the payloads are different, it writes the reference payload into the target tag using PoolDBOutputService.

A complete example is provided for the EcalADCToGeVConstant class.

@mmusich @franzoni this is something you might want to watch as well.

cmsbuild · 2016-10-18T13:51:31Z

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_8_1_X.

It involves the following packages:

CondCore/DBOutputService
CondTools/Ecal

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

mmusich · 2016-10-18T13:52:32Z

please test

cmsbuild · 2016-10-18T13:52:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15790/console

cmsbuild · 2016-10-18T14:55:56Z

+1
Tested at: f0cc358
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16248/15790/summary.html

diguida · 2016-10-18T16:03:21Z

@smuzaffar question: what does

Additional comment: 'materialbudget'

mean in #16248 (comment)

mmusich · 2016-10-18T16:04:12Z

seems it has been introduced here:
cms-sw/cms-bot@3adf702

cmsbuild · 2016-10-18T16:29:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16248/15790/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimHLBeamSpotFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing

…ntSetup and PoolDBOutputService. An example is provided for EcalADCToGeVConstant.

…ols/RunInfo: it is a tool manipulating tags based on a condition on the magnet current as seen in the RunInfo payloads.

cmsbuild · 2016-10-18T17:34:50Z

Pull request #16248 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

diguida · 2016-10-18T17:38:43Z

Small fixes:

rebased to latest IB
the analyzer is now in CondTools/RunInfo as it manipulates tags based on then magnet current as seen by the RunInfo payloads.

mmusich · 2016-10-18T18:20:32Z

please test

cmsbuild · 2016-10-18T18:20:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15802/console

cmsbuild · 2016-10-18T19:45:00Z

+1
Tested at: 3e05de0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16248/15802/summary.html
Additional comment: 'materialbudget'

cmsbuild · 2016-10-18T21:04:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16248/15802/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimHLBeamSpotFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing

smuzaffar · 2016-10-18T21:41:41Z

@diguida, please ignore that. I was testing cms-bot reporting script.

ggovi · 2016-10-25T14:52:29Z

+1

cmsbuild · 2016-10-25T14:54:31Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

davidlange6 · 2016-10-26T15:05:20Z

+1

ghellwig · 2016-10-26T15:20:52Z

CondTools/RunInfo/interface/BTransitionAnalyzer.h

+  public:
+    BTransitionAnalyzer( const edm::ParameterSet& pset ):
+      m_currentThreshold( pset.getUntrackedParameter<double>( "currentThreshold", 18000. ) ) {
+      usesResource( "PoolDBOutputService" );


@diguida I have just one comment/question. You declare that you use the resource "PoolDBOutputService". As I understood, this is only needed, if the resource is not thread-safe. However, @Dr15Jones commented in this HN thread that it appears to be thread-safe.
Do you have reasons to declare it anyways, except that "appears to be thread-safe" might be a bit vague?

@ghellwig sorry for late reply.
As discussed few minutes ago at the AlCaDB meeting, the code here was originally developed in 7.4.X, where PoolDBOutputService was not thread safe.
According to the API description

The system makes sure that only one module which has declared a usage of a specific resource will ever be run at a time. That is, the system will serialize all calls to all modules which declare that resource.

In the online context of the O2O, a cmsRun job will call only this module (apart from input sources), so, even if formally the performance penalty is introduced, operationally it should not be visible. Besides this, in that context you care more of the correctness of the database transactions than of the performance of job: if you have a fast job potentially writing wrong IOV, this is a big problem.

Anyhow, if also @Dr15Jones agrees that the usesResource is not needed, I can put a PR removing it.

HTH

P.S.: you were also saying another observation at the meeting, but I did not catch it. Feel free to post it here.

@diguida thanks for the clarification!
My other comment does not apply anymore, but I list it here for reference: You write usesResource("PoolDBOutputService");, but in general it is better practice to define a static const string in PoolDBOutputService and use this to avoid typos because the compiler checks the name of the variable which is not the case if you use a hard-coded string everytime the resource is used.

@ghellwig you are absolutely right! This is common sense (as well as a software best practice):

adding a static data member using constant expression for labelling the framework service name:static constexpr auto serviceName = "PoolDBOutputService";

using it every time you refer to the service name in client code: usesResource( std::string( PoolDBOutputService::serviceName ) );

Dr15Jones · 2016-11-02T13:52:53Z

I used 'appears' just to give me wiggle room in case I missed something. The code is definitely intended to be thread safe so I would therefore suggest not using a 'SharedResource' for the Service. If we later discover a thread-safety problem, we'll treat that as a bug in the Service and fix the Service.

diguida · 2016-11-02T13:54:40Z

@Dr15Jones thanks for looking into this.
I am submitting a PR with the fix.

I also owe you a reply in a private thread on a similar topic: sorry about that, will come back to you later today.

diguida · 2016-11-02T14:24:52Z

FYI: #16427

cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 18, 2016

cmsbuild added alca-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Oct 18, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 18, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 18, 2016

Salvatore Di Guida added 2 commits October 18, 2016 19:10

New template analyzer for dealing with B ON/OFF transitions using Eve…

0fca554

…ntSetup and PoolDBOutputService. An example is provided for EcalADCToGeVConstant.

Move the implementation of the EDAnalyzer for B transitions in CondTo…

3e05de0

…ols/RunInfo: it is a tool manipulating tags based on a condition on the magnet current as seen in the RunInfo payloads.

diguida force-pushed the BTransition_EDAnalyzer_81X_v0 branch from f0cc358 to 3e05de0 Compare October 18, 2016 17:34

cmsbuild added comparison-pending tests-pending and removed alca-pending comparison-available tests-approved labels Oct 18, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 18, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 18, 2016

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Oct 25, 2016

cmsbuild added orp-approved and removed orp-pending labels Oct 26, 2016

cmsbuild merged commit 331b38f into cms-sw:CMSSW_8_1_X Oct 26, 2016

ghellwig reviewed Oct 26, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New template one::EDAnalyzer for dealing with B ON/OFF transitions using EventSetup and PoolDBOutputService. #16248

New template one::EDAnalyzer for dealing with B ON/OFF transitions using EventSetup and PoolDBOutputService. #16248

diguida commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

mmusich commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 •

edited

cmsbuild commented Oct 18, 2016 •

edited by smuzaffar

diguida commented Oct 18, 2016

mmusich commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

diguida commented Oct 18, 2016

mmusich commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 •

edited

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

smuzaffar commented Oct 18, 2016

ggovi commented Oct 25, 2016

cmsbuild commented Oct 25, 2016

davidlange6 commented Oct 26, 2016

ghellwig Oct 26, 2016

diguida Oct 31, 2016

ghellwig Oct 31, 2016

diguida Oct 31, 2016 •

edited

Dr15Jones commented Nov 2, 2016

diguida commented Nov 2, 2016

diguida commented Nov 2, 2016

New template one::EDAnalyzer for dealing with B ON/OFF transitions using EventSetup and PoolDBOutputService. #16248

New template one::EDAnalyzer for dealing with B ON/OFF transitions using EventSetup and PoolDBOutputService. #16248

Conversation

diguida commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

mmusich commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 • edited

cmsbuild commented Oct 18, 2016 • edited by smuzaffar

diguida commented Oct 18, 2016

mmusich commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

diguida commented Oct 18, 2016

mmusich commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 • edited

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

smuzaffar commented Oct 18, 2016

ggovi commented Oct 25, 2016

cmsbuild commented Oct 25, 2016

davidlange6 commented Oct 26, 2016

ghellwig Oct 26, 2016

Choose a reason for hiding this comment

diguida Oct 31, 2016

Choose a reason for hiding this comment

ghellwig Oct 31, 2016

Choose a reason for hiding this comment

diguida Oct 31, 2016 • edited

Choose a reason for hiding this comment

Dr15Jones commented Nov 2, 2016

diguida commented Nov 2, 2016

diguida commented Nov 2, 2016

cmsbuild commented Oct 18, 2016 •

edited

cmsbuild commented Oct 18, 2016 •

edited by smuzaffar

cmsbuild commented Oct 18, 2016 •

edited

diguida Oct 31, 2016 •

edited