Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1TGlobalPrescaler: additional modes based on the prescales in the EventSetup (8.1.x) #16261

Merged
merged 1 commit into from Oct 31, 2016
Merged

L1TGlobalPrescaler: additional modes based on the prescales in the EventSetup (8.1.x) #16261

merged 1 commit into from Oct 31, 2016

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 18, 2016

Additional modes based on the prescales in the EventSetup:

  • applyPrescaleValues: apply the given prescale values (original behaviour)
  • applyPrescaleRatios: apply prescales equal to ratio between the given values and the ones read from the EventSetup
  • applyColumnValues: apply the prescale values from the EventSetup corresponding to the given column index
  • applyColumnRatios: apply prescales equal to ratio between the values corresponsing to the given column index, and the ones read from the EventSetup

In the last two cases, also sets the prescale column index to the given one.

@fwyzard
L1TGlobalPrescaler: additional modes based on the prescales in the Ev…
5d15af7 
…entSetup

  - applyPrescaleValues: apply the given prescale values (original behaviour)
  - applyPrescaleRatios: apply prescales equal to ratio between the given
                         values and the ones read from the EventSetup
  - applyColumnValues:   apply the prescale values from the EventSetup
                         corresponding to the given column index
  - applyColumnRatios:   apply prescales equal to ratio between the values
                         corresponsing to the given column index, and the
                         ones read from the EventSetup

In the last two cases, also sets the prescale column index to the given one.
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 18, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 18, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15811/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 18, 2016

@rekovic, @mulhearn, can you sign this ?

@cmsbuild
Copy link
Contributor

+1
Tested at: 5d15af7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16261/15811/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
235c552
bb1721a
46c7c4d
9290ce3
adf8960
a95432d
24cf407
f6cbf0c
a79da66
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16261/15811/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16261/15811/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16261/15811/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
  • 22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimHLBeamSpotFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 19, 2016

Please note that this module is not used in any central workflows.

@davidlange6
Copy link
Contributor

@rekovic - any comments on this PR?

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 31, 2016

@rekovic, @mulhearn, can you please comment if there are any issues with this PR, or otherwise sign it ?

@davidlange6
Copy link
Contributor

seems they managed to sign the 80x pr - so I'll merge this one

@davidlange6 davidlange6 merged commit fb18942 into cms-sw:CMSSW_8_1_X Oct 31, 2016
@fwyzard fwyzard deleted the L1TGlobalPrescaler_from_EventSetup_81x branch December 1, 2016 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbuild @davidlange6