Update to Hcal Validation #16286

kencall · 2016-10-20T17:28:42Z

This is a follow-up to PR #15714, it includes the following changes:

Uses getHxSize to obtain the number of channels per subdetector
N_Hx range based on number of channels
phi segmentation and ieta range taken from geometry
initialize std::vector without for loops
HO emean_vs_ieta, occupancy_maps filled

RecHit StatusWord and AuxStatus histograms are normalized by number of channels per subdet, as well as by nevts

Uses getHxSize to obtain the number of channels per subdtector N_Hx range based on number of channels phi segmentation and ieta range taken from geometry initialize std::vector without for loops HO emean_vs_ieta, occupancy_maps filled iphi and ieta are no longer adjusted to remove ieta==0, and iphi ranges from 1..72

…f channels per subdet, as well as by nevts.

cmsbuild · 2016-10-20T17:29:05Z

A new Pull Request was created by @kencall for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Hcal

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

dmitrijus · 2016-10-21T10:54:42Z

+1

cmsbuild · 2016-10-21T10:55:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15875/console

cmsbuild · 2016-10-21T10:55:00Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

cmsbuild · 2016-10-21T12:59:57Z

+1
Tested at: abd3779
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16286/15875/summary.html

cmsbuild · 2016-10-21T12:59:59Z

Comparison job queued.

cmsbuild · 2016-10-21T13:48:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16286/15875/summary.html

davidlange6 · 2016-10-21T15:08:24Z

DQMOffline/Hcal/interface/HcalRecHitsAnalyzer.h

@@ -83,6 +84,12 @@ class HcalRecHitsAnalyzer : public DQMEDAnalyzer {

  int nChannels_[5]; // 0:any, 1:HB, 2:HE

+  int iphi_bins;


@kencall -please end member data with a _ (seems to be the convention this code has, which is a good one)

davidlange6 · 2016-10-21T15:10:44Z

DQMOffline/Hcal/interface/HcalRecHitsDQMClient.h

@@ -47,13 +59,19 @@ class HcalRecHitsDQMClient : public DQMEDHarvester {
  std::string dirNameJet_;
  std::string dirNameMET_;

+  edm::ESHandle<CaloGeometry> geometry ;


is this used outside of the function that defines it ? If not, no need for it to be a member data

Update the bin error of scaled histograms

kencall · 2016-11-04T05:23:46Z

I'm fixing it.

cmsbuild · 2016-11-04T20:22:09Z

Pull request #16286 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

kencall · 2016-11-04T20:23:14Z

Segfault was due to calling an object which had been deleted. This is fixed.

kpedro88 · 2016-11-04T20:49:34Z

@cmsbuild please test

cmsbuild · 2016-11-04T20:49:52Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16208/console

cmsbuild · 2016-11-04T22:53:18Z

+1
Tested at: 2f7ce02
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16286/16208/summary.html

cmsbuild · 2016-11-04T22:53:21Z

Comparison job queued.

cmsbuild · 2016-11-05T01:52:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16286/16208/summary.html

kpedro88 · 2016-11-06T19:50:46Z

@davidlange6 is this okay now?

dmitrijus · 2016-11-08T12:58:12Z

+1

cmsbuild · 2016-11-08T12:58:26Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

davidlange6 · 2016-11-08T15:14:11Z

+1

kencall added 2 commits October 12, 2016 14:16

RecHit StatusWord and AuxStatus histograms are normalized by number o…

abd3779

…f channels per subdet, as well as by nevts.

cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 20, 2016

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Oct 20, 2016

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 21, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 21, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 21, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 21, 2016

davidlange6 reviewed Oct 21, 2016

View reviewed changes

Standardized member variables

73c67da

Update the bin error of scaled histograms

cmsbuild removed comparison-available dqm-approved labels Oct 21, 2016

HcalRecHitsAnalyzer::fillRecHitsTmp, requires a current geometry object

2f7ce02

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Nov 4, 2016

cmsbuild added tests-started and removed tests-pending labels Nov 4, 2016

cmsbuild added tests-approved and removed tests-started labels Nov 4, 2016

cmsbuild added comparison-available and removed comparison-pending labels Nov 5, 2016

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 8, 2016

cmsbuild added orp-approved and removed orp-pending labels Nov 8, 2016

cmsbuild merged commit e629e0a into cms-sw:CMSSW_8_1_X Nov 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Hcal Validation #16286

Update to Hcal Validation #16286

kencall commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

dmitrijus commented Oct 21, 2016

cmsbuild commented Oct 21, 2016 •

edited

cmsbuild commented Oct 21, 2016

cmsbuild commented Oct 21, 2016

cmsbuild commented Oct 21, 2016

cmsbuild commented Oct 21, 2016

davidlange6 Oct 21, 2016

davidlange6 Oct 21, 2016

kencall commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

kencall commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 •

edited

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 5, 2016

kpedro88 commented Nov 6, 2016

dmitrijus commented Nov 8, 2016

cmsbuild commented Nov 8, 2016

davidlange6 commented Nov 8, 2016

		@@ -83,6 +84,12 @@ class HcalRecHitsAnalyzer : public DQMEDAnalyzer {

		int nChannels_[5]; // 0:any, 1:HB, 2:HE

		int iphi_bins;

Update to Hcal Validation #16286

Update to Hcal Validation #16286

Conversation

kencall commented Oct 20, 2016

cmsbuild commented Oct 20, 2016

dmitrijus commented Oct 21, 2016

cmsbuild commented Oct 21, 2016 • edited

cmsbuild commented Oct 21, 2016

cmsbuild commented Oct 21, 2016

cmsbuild commented Oct 21, 2016

cmsbuild commented Oct 21, 2016

davidlange6 Oct 21, 2016

Choose a reason for hiding this comment

davidlange6 Oct 21, 2016

Choose a reason for hiding this comment

kencall commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

kencall commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 • edited

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 5, 2016

kpedro88 commented Nov 6, 2016

dmitrijus commented Nov 8, 2016

cmsbuild commented Nov 8, 2016

davidlange6 commented Nov 8, 2016

cmsbuild commented Oct 21, 2016 •

edited

cmsbuild commented Nov 4, 2016 •

edited