[81X] enable fetching of phase-I geometry from DB

[mmusich]

This PR re-introduces in the 2017 phase-I workflows the fetching of the geometry from DB.
It should contain the state of the art of the tags for geometry description of the detector.
Current status (as of Oct 27th) of the changes:

Summary of changes in Global Tags

Upgrade

• PhaseI realistic scenario : 81X_upgrade2017_realistic_v20 as 81X_upgrade2017_realistic_v19 with the following changes:
  • updated Phase-I geometry: fixes the problem with CutTubs observed in GeometryFileRcd (81YV11) as well as a problem with mixing vector content in an Hcal reco schema (relevant code changes are already in pre13) and aligns sim geometry and Tracker reco geometry to a current one built from xml.
  • updated Tracker alignment (ideal Pixel + asymptotic misalignment scenario for Strips) consistently with Tracker geometry
• PhaseI design scenario : 81X_upgrade2017_design_IdealBS_v4 as 81X_upgrade2017_design_IdealBS_v3 with the following changes:
  • updated Phase-I geometry: fixes the problem with CutTubs observed in GeometryFileRcd (81YV11) as well as a problem with mixing vector content in an Hcal reco schema (relevant code changes are already in pre13) and aligns sim geometry and Tracker reco geometry to a current one built from xml.
  • updated Tracker alignment (ideal Pixel + ideal Strips) consistently with Tracker geometry

Tracker alignment payloads are from @ghellwig
This PR also re-activates the alignment on top of the geometry in case it is fetched via XML.
@makortel you might want to follow this PR in its current state

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15877/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15878/console

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation

@ghellwig, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @mmusich, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[ianna]

@mmusich - looks good to me, thanks.

[cmsbuild]

-1

Tested at: 8692394

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16301/15878/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
10024.0 step1

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10021.0 step1

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step1_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[mmusich]

@ianna, updating the GT with those updated geometry configuration results in segfault in the simulation step:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16301/15878/runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step1_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

could you please have a look?

[ianna]

@mmusich - ok, I'm checking

[ianna]

@mmusich - it looks like the DB tag is fine, I can access it and dump it:

cmsRun GeometryReaders/XMLIdealGeometryESSource/test/testReadXMLFromGTDB.py 

I'm checking the XML parser.

[ianna]

@mmusich - FYI, a bugfix is on the way. I'll update the tags. Please, close this PR.

[mmusich]

@ianna, thanks for the update. I'll update the autoCond with new GTs when we have the new tags at hand. Thanks.

[ianna]

@mmusich - please, take a new tag for GeometryFileRcd:

XMLFILE_Geometry_81YV12_Extended2017new_mc

The rest of the new tags in this GT queue are ok.

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16301/15998/summary.html

[fabozzi]

+1

[mmusich]

+1
comparison with baseline show changes across the board in 2017 workflows, but I am unable to find instances of huge issues in the plots in:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_8_1_X_2016-10-26-2300+16301/16591/validateJR/all_OldVSNew_TTbar13TeV2017wf10024p0/

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[kpedro88]

@mmusich changes could be due to random number fluctuations from loading DB vs XML geometries

[mmusich]

@kpedro88 yep, was trying also to look if switch the alignment back on is causing issues - it appears like it's not the case (on the limited PR relval stats)

[davidlange6]

+1