Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change L1 menu for HLT tests with phase1 2017 geometry #16332

Merged
merged 2 commits into from Oct 26, 2016

Conversation

silviodonato
Copy link
Contributor

This PR is needed to run the HLT GRun menu with the new phase1 2017 geometry.
It overwrites the L1 menu in the global tag to use the correct one.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_8_1_X.

It involves the following packages:

Configuration/HLT

@perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@silviodonato
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 24, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15931/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

@silviodonato @mmusich
autoCondHLT.py contains our "own" TSG symbolic GTs. We should not change existing official GTs, those should be changed by the AlCa team only. Marco, can you have a look at updating the L1T menu in the 2017 GTs?

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2016

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Oct 25, 2016
@cmsbuild
Copy link
Contributor

Pull request #16332 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@silviodonato
Copy link
Contributor Author

I renamed the symbolic GT in order to avoid to overwrite the existing GT.
@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15937/console

@Martin-Grunewald
Copy link
Contributor

@mmusich
In principle yes, but at one point we'll leave 2016 behind, esp. when we move to the real 2017 menu
in 2017.

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2016

@Martin-Grunewald done in #16339

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2016

@silviodonato please rename this PR to reflect the actual meaning of it - I'll remove the hold

@silviodonato silviodonato changed the title Fix L1 menu used in phase1_2017 GTs Change L1 menu for HLT tests with phase1 2017 geometry Oct 25, 2016
@silviodonato
Copy link
Contributor Author

@mmusich , thanks. I've changed the title

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2016

unhold

@cmsbuild cmsbuild removed the hold label Oct 25, 2016
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@silviodonato
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

i take it that #16339 supersedes this PR?

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2016

@davidlange6 IMHO, TSG people use case i.e. to create their own customized autoCond keys is a legitimate one, provided they never EVER end up being used in production

@davidlange6
Copy link
Contributor

+1

@mmusich - thanks - indeed the PR was not doing what I thought it was before.

@cmsbuild cmsbuild merged commit ff3bc38 into cms-sw:CMSSW_8_1_X Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants