New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change L1 menu for HLT tests with phase1 2017 geometry #16332
Conversation
A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_8_1_X. It involves the following packages: Configuration/HLT @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
@silviodonato @mmusich |
hold |
Pull request has been put on hold by @mmusich |
Pull request #16332 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again. |
I renamed the symbolic GT in order to avoid to overwrite the existing GT. |
The tests are being triggered in jenkins. |
@mmusich |
@Martin-Grunewald done in #16339 |
@silviodonato please rename this PR to reflect the actual meaning of it - I'll remove the hold |
@mmusich , thanks. I've changed the title |
unhold |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
i take it that #16339 supersedes this PR? |
@davidlange6 IMHO, TSG people use case i.e. to create their own customized autoCond keys is a legitimate one, provided they never EVER end up being used in production |
+1 @mmusich - thanks - indeed the PR was not doing what I thought it was before. |
This PR is needed to run the HLT GRun menu with the new phase1 2017 geometry.
It overwrites the L1 menu in the global tag to use the correct one.