Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track history fixes backport80 x #16377

Merged
merged 7 commits into from Dec 19, 2016

Conversation

smoortga
Copy link
Contributor

This PR is simply a backport to 80X from the following PRs in 81X (already merged)
#16161
#16280
#16367 (Fully-approved, orp-pending)

It applies some fixes to the TrackHistory code needed for Track monitoring in the BTV group.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smoortga for CMSSW_8_0_X.

It involves the following packages:

SimTracker/TrackHistory
SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @makortel, @threus, @acaudron, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @JyothsnaKomaragiri, @mverzett, @wmtford, @ferencek, @pvmulder, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor

civanch commented Oct 28, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16023/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Oct 29, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@smoortga
Copy link
Contributor Author

smoortga commented Nov 7, 2016

Dear, @civanch, @mdhildreth, @davidlange6, @slava77, @smuzaffar
May I ask what is the current status of this PR? It has been on 'orp-pending' for 18 days now so I was wondering if this is ready to be merged?

Thanks in advance,
Cheers,
Seth Moortgat

@smoortga
Copy link
Contributor Author

Dear, @civanch, @mdhildreth, @davidlange6, @slava77, @smuzaffar

Could you please inform me on when this PR might get merged (or what is holding it back to be merged if that is the case)?

Thanks,
Cheers,
Seth Moortgat

@ghost
Copy link

ghost commented Dec 7, 2016

Dear @civanch @mdhildreth @davidlange6 @slava77 @smuzaffar
a kind reminder. Thanks

@smoortga
Copy link
Contributor Author

Dear @civanch @mdhildreth @davidlange6 @slava77 @smuzaffar,
As this PR has been fully signed more than a month ago, could this please be merged? These changes will be needed in order to continue this project and make an implementation in the offline DQM. This is becoming rather urgent since the application for DQM is nearly ready, but can only be merged once this PR has been merged as well.

Thanks,

Cheers
Seth

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 16fb0f2 into cms-sw:CMSSW_8_0_X Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants