Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy-download handling of file systems that are mounted more than once #16409

Merged

Conversation

dan131riley
Copy link

When checking for a local file system for lazy download, handle the case where a file system is listed more than once in /proc/self/mounts by checking same-length path matches until a local file system is found. Workaround for issue found with Tier0 merge jobs on VMs where / is the only file system:

https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3689.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_8_1_X.

It involves the following packages:

Utilities/StorageFactory

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16117/console

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@Dr15Jones
Copy link
Contributor

@davidlange6 this is a change we are testing to solve the Tier 0 lazy-download problem.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

Comparison job queued.

@davidlange6
Copy link
Contributor

Right - how do we test that it works before this reaches the tier0?

On Nov 1, 2016, at 3:37 PM, Chris Jones notifications@github.com wrote:

@davidlange6 this is a change we are testing to solve the Tier 0 lazy-download problem.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 51edd2c into cms-sw:CMSSW_8_1_X Nov 1, 2016
@dan131riley dan131riley deleted the LocalFileSystem-prefer-local branch October 9, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants