New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase I Beampipe Overlap Fix #16412
Phase I Beampipe Overlap Fix #16412
Conversation
please test |
+1 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X. It involves the following packages: Geometry/CMSCommonData @civanch, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@davidlange6 - this PR needs only geometry signature because the rest of changes come from an already merged #16401, but it looks like PR rebasing does not show it yet. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Comparison job queued. |
+1 |
Note, based on (already merged) #16401
before and after the fix: