Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase I Beampipe Overlap Fix #16412

Merged
merged 20 commits into from Nov 1, 2016
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Nov 1, 2016

  • Extend BEAM Air envelope to cover both bellows

Note, based on (already merged) #16401

before and after the fix:
screenshot 2016-11-01 16 00 15
screenshot 2016-11-01 15 59 37

@ianna
Copy link
Contributor Author

ianna commented Nov 1, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Nov 1, 2016
@ianna
Copy link
Contributor Author

ianna commented Nov 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16118/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

Geometry/CMSCommonData
Geometry/TrackerRecoData
SimTracker/TrackerMaterialAnalysis
Validation/Geometry

@civanch, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor Author

ianna commented Nov 1, 2016

@davidlange6 - this PR needs only geometry signature because the rest of changes come from an already merged #16401, but it looks like PR rebasing does not show it yet.

@dmitrijus
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Nov 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 585dcfa into cms-sw:CMSSW_8_1_X Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants