bsunanda:Phase2-hgx66 Extend virtual wafer to valid list of DetIds

[bsunanda]

This is a step toward having the complete cells in the reconstruction step.

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Geometry/HGCalCommonData
Geometry/HGCalGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16134/console

[cmsbuild]

-1

Tested at: f014ed0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16419/16134/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16419/16134/summary.html

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16156/console

[cmsbuild]

-1

Tested at: f014ed0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16419/16156/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #16419 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @rekovic, @slava77, @mulhearn, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16158/console

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16419/16156/summary.html

[cmsbuild]

+1
Tested at: 3f96ac8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16419/16158/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16419/16158/summary.html

[ianna]

+1

[slava77]

+1

for #16419 3f96ac8

• reco is minimally affected: only in RecoLocalCalo/HGCalRecProducers/test/testHGCalRecoLocal_cfg.py
• jenkins tests pass and comparisons show no differences, including the tested 2023 workflows

[bsunanda]

@rekovic @mulhearn Please approve this. There is only a small correction in the BuildFile in one L1 package.